Re: nilfs_cpfile_delete_checkpoints: cannot delete block

[David Arendt <admin-/LHdS3kC8BfYtjvyW6yDsg@public.gmane.org>]

Hi,

This night. I had lots of:

nilfs_btree_propagate: key = 67, level == 0

On the parition where cleanerd has failed.

A try to umount it resulted in a hang with the following message:

NILFS warning (device sda10): nilfs_segctor_destroy: dirty file(s) after 
the final construction

Bye,
David Arendt

Ryusuke Konishi wrote:
> Hi David,
> On Sun, 03 May 2009 00:55:43 +0200, David Arendt wrote:
>   
>> Hi,
>>
>> Until now nilfs-2.0.12 has run very stable without data corruption.
>> However on one partition (600G) I have got the following errors while 
>> running the cleaner:
>>
>> nilfs_cpfile_delete_checkpoints: cannot delete block
>> NILFS: GC failed during preparation: cannot delete checkpoints: err=-2
>>
>> This is a partition mainly holding large temporary render files (can be 
>> up to 25gb/file). There are currently 132702 snapshots.
>>
>> As this partition is not used during the next few days, I will leave it 
>> with the error so if you would like me to test further things, please 
>> let me know.
>>
>> Bye,
>> David Arendt
>>     
>
> I have reviewed the function in question, but could not find any
> likely problems.
>
> Could you try the following patch?
>
> It's applicable to v2.0.12.
>
> I have some pending patches later than 2.0.12, but they seem to be
> independent with your problem.
>
> Thanks,
> Ryusuke Konishi
> --
> diff --git a/fs/cpfile.c b/fs/cpfile.c
> index 038d660..9a6a6ae 100644
> --- a/fs/cpfile.c
> +++ b/fs/cpfile.c
> @@ -342,8 +342,12 @@ int nilfs_cpfile_delete_checkpoints(struct inode *cpfile,
>  					cpfile, cno);
>  				if (ret == 0)
>  					continue;
> -				printk(KERN_ERR "%s: cannot delete block\n",
> -				       __func__);
> +				printk(KERN_ERR "%s: cannot delete block: "
> +				       "cno=%llu, range = [%llu, %llu)\n",
> +				       __func__,
> +				       (unsigned long long)cno,
> +				       (unsigned long long)start,
> +				       (unsigned long long)end);
>  				goto out_sem;
>  			}
>  		}
> diff --git a/fs/dat.c b/fs/dat.c
> index 523eee7..7463301 100644
> --- a/fs/dat.c
> +++ b/fs/dat.c
> @@ -381,11 +381,9 @@ int nilfs_dat_translate(struct inode *dat, __u64 vblocknr, sector_t *blocknrp)
>  	entry = nilfs_palloc_block_get_entry(dat, vblocknr, entry_bh, kaddr);
>  	blocknr = le64_to_cpu(entry->de_blocknr);
>  	if (blocknr == 0) {
> -#ifdef CONFIG_NILFS_DEBUG
>  		printk(KERN_DEBUG "%s: invalid virtual block number: %llu\n",
>  		       __func__, (unsigned long long)vblocknr);
> -		BUG();
> -#endif
> +		WARN_ON(1);
>  		ret = -ENOENT;
>  		goto out;
>  	}
>