From: Adrian Hunter <adrian.hunter@nokia.com>
To: Tony Lindgren <tony@atomide.com>
Cc: vimal singh <vimalsingh@ti.com>,
"dedekind@infradead.org" <dedekind@infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atommide.com>
Subject: Re: [PATCH] onenand_init: Allow disabling sync read and write based on flags (Re: [PATCH 1/4] onenand init: Rename board-n800-flash.c to gpmc-onenand.c)
Date: Mon, 04 May 2009 11:27:57 +0300 [thread overview]
Message-ID: <49FEA70D.8070704@nokia.com> (raw)
In-Reply-To: <20090430185307.GF12986@atomide.com>
Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [090430 07:06]:
>> * vimal singh <vimalsingh@ti.com> [090429 23:33]:
>>> 'gpmc-onenand.c' is still confusing name. This is not going to used in
>>> all boards anyway.
>> Why do you think this cannot be used for all boards?
>>
>> The GPMC timings are totally based on the onenand chip features.
>
> And these two patches make omap3430sdp to work with the gpmc-onenand
> code. Sync mode does not work, but it seems like it was never enabled
> for sdp anyways.
>
> Similar patch should work for other boards too.
>
> Tony
>
This is not quite right. OneNAND only allows 3 possibilities:
1. Async: call 'omap2_onenand_set_async_mode()'
2. Sync Read: call 'omap2_onenand_set_sync_mode()' but force 'sync_write' variable to be always zero
3. Sync Read and Sync Write: call 'omap2_onenand_set_sync_mode()' as now
next prev parent reply other threads:[~2009-05-04 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 6:33 [PATCH 1/4] onenand init: Rename board-n800-flash.c to gpmc-onenand.c vimal singh
2009-04-30 14:03 ` Tony Lindgren
2009-04-30 18:53 ` [PATCH] onenand_init: Allow disabling sync read and write based on flags (Re: [PATCH 1/4] onenand init: Rename board-n800-flash.c to gpmc-onenand.c) Tony Lindgren
2009-04-30 18:59 ` [PATCH] onenand init: Convert omap3430sdp to use gpmc-onenand (Re: [PATCH] onenand_init: Allow disabling sync read and write based on flags (Re: [PATCH 1/4] onenand init: Rename board-n800-flash.c to gpmc-onenand.c)) Tony Lindgren
2009-05-01 17:38 ` [PATCH] onenand_init: Allow disabling sync read and write based on flags, v2 (Re: [PATCH 1/4] onenand init: Rename board-n800-flash.c to gpmc-onenand.c) Tony Lindgren
2009-05-04 8:27 ` Adrian Hunter [this message]
2009-05-04 17:39 ` [PATCH] onenand_init: Allow disabling sync read and write based on flags, v3 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FEA70D.8070704@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=dedekind@infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=tony@atommide.com \
--cc=vimalsingh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.