Avi Kivity wrote: > Jes Sorensen wrote: >> +int destroy_region_works = 0; > > Global name, prefix with kvm_. Does it actually need to be global? Gone, now local to qemu-kvm-x86.c. I moved the initializer into kvm_arch_create_context() instead. > The header depends on target_phys_addr_t, so it must include whatever > defines it. Added an #include "cpu-all.h" which defines it. > Missing other archs... > > Instead of duplicating this for every arch, you can have a #define that > tells you if you want non-trivial arch definitions, and supply the > trivial definitions in qemu-kvm.h. Done, I also added a PPC header file - which may or may not be wanted at this point. You can just cut it out if you don't think it should be added. What do you think of this version then? Cheers, Jes