From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Wrong conflicts on file splits
Date: Mon, 04 May 2009 15:49:14 +0200 [thread overview]
Message-ID: <49FEF25A.3090305@drmicha.warpmail.net> (raw)
In-Reply-To: <9e4733910905040642h5932e80ds5c467db90e03f40d@mail.gmail.com>
Jon Smirl venit, vidit, dixit 04.05.2009 15:42:
> On Mon, May 4, 2009 at 9:27 AM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> Jon Smirl venit, vidit, dixit 04.05.2009 14:53:
>>> I keep running into this problem, is there anything I can do to make
>>> it better? I'm using stgit but this is a problem in git itself.
>>>
>>> I have a patch that splits file A into two files, A and B.
>>> Now I merge with another tree and bring in a one line fix to A.
>>> The fix touches the pre-split file A in a section that is going to end up in B.
>>> Next I re-apply the patch that splits A into A and B.
>>>
>>> This results in a large conflict in the post split file A.
>>> And no patch being applied to file B which is where the fix belongs.
>>>
>>> Repeat this process with a multi-line fix and the whole automated
>>> merge process breaks down and I have to carefully figure everything
>>> out by hand.
>>>
>>> The merge process seems to be unaware of the newly created file B. No
>>> patches or conflict ever end up in it.
>>>
>>
>> Can you provide a test case or at least a list of commands which you are
>> issuing? You complain about "merge", but you say you are "applying a
>> patch". Are you merging that patch from another branch, or are you
>> really applying it as a patch (git-apply/cherry-pick/rebase/what-not)?
>
> What git command does stgit use internally on push/pop?
>
> It's the stg push of a patch creating a split on top of a change to
> the section that is going to end up in file B that causes the problem.
I see. So it's really rebasing/applying here rather then merging. I
don't think they have the necessary info in order to do content-based
patching across file boundaries.
Michael
next prev parent reply other threads:[~2009-05-04 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 12:53 Wrong conflicts on file splits Jon Smirl
2009-05-04 13:27 ` Michael J Gruber
2009-05-04 13:42 ` Jon Smirl
2009-05-04 13:49 ` Michael J Gruber [this message]
2009-05-04 13:52 ` Jon Smirl
2009-05-04 14:54 ` Michael J Gruber
2009-05-04 15:30 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FEF25A.3090305@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.