From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH 1/2] ipc: clearn up code
Date: Fri, 20 Apr 2018 22:41:52 +0800
Message-ID: <49f118dd-d369-99cf-eae5-b3f6271cbabb@intel.com>
References: <1524187312-129804-1-git-send-email-jianfeng.tan@intel.com>
 <1524187312-129804-2-git-send-email-jianfeng.tan@intel.com>
 <93e616c5-292a-98ee-041b-462c098e90d0@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: thomas@monjalon.net
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 87CD8AAE8
 for <dev@dpdk.org>; Fri, 20 Apr 2018 16:41:56 +0200 (CEST)
In-Reply-To: <93e616c5-292a-98ee-041b-462c098e90d0@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 4/20/2018 3:55 PM, Burakov, Anatoly wrote:
> On 20-Apr-18 2:21 AM, Jianfeng Tan wrote:
>> Following below commit, we change some internal function and variable
>> names:
>>    commit ce3a7312357b ("eal: rename IPC request as synchronous one")
>>
>> Also use calloc to supersede malloc + memset for code clean up.
>>
>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>> ---
>
> In general,
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> However, i think it would be good to have it rebased/applied on top of 
> IPC coverity fixes, in particular because this patch uses strcpy 
> instead of instead of strlcpy.

Will rebase on those fixes patches. And send the v2.

Thanks,
Jianfeng