From: Michael Tokarev <mjt@tls.msk.ru>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Andi Kleen <andi@firstfloor.org>,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: compat ioctl32 for /dev/snapshot?
Date: Tue, 05 May 2009 15:43:08 +0400 [thread overview]
Message-ID: <4A00264C.3020004@msgid.tls.msk.ru> (raw)
In-Reply-To: <200905051338.46436.arnd@arndb.de>
Arnd Bergmann wrote:
> On Monday 04 May 2009, Rafael J. Wysocki wrote:
>> In fact I don't think the 32-bit user space will work with 64-bit kernels as is
>> in this particular case, because of the different pointer size.
>>
>> Having a quick look at the code (I don't remember the details right now)
>> I think most probably it could be modified to handle this case too, but I'm not
>> really sure.
>
> I don't see anything in the snapshot code that passes pointers to the
> kernel, so why should the pointer size matter?
It's the userspace part (uswsusp). In particular it parses swap
on-disk data structures.
But in any case, without compat_ioctl32 in kernel userspace part
can not be fixed.
/mjt
next prev parent reply other threads:[~2009-05-05 11:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 9:29 compat ioctl32 for /dev/snapshot? Michael Tokarev
2009-05-04 9:35 ` Andi Kleen
2009-05-04 10:55 ` Michael Tokarev
2009-05-04 11:12 ` Andi Kleen
2009-05-04 21:55 ` Rafael J. Wysocki
2009-05-05 11:38 ` Arnd Bergmann
2009-05-05 11:43 ` Michael Tokarev [this message]
2009-05-05 23:13 ` Rafael J. Wysocki
2009-05-04 11:52 ` Arnd Bergmann
2009-05-04 22:26 ` Michael Tokarev
2009-05-05 10:58 ` Arnd Bergmann
2009-05-04 21:58 ` Rafael J. Wysocki
2009-07-10 16:21 ` Pavel Machek
2009-07-12 0:19 ` Michael Tokarev
2009-07-12 15:07 ` Arnd Bergmann
2009-07-13 6:51 ` Michael Tokarev
2009-07-13 20:21 ` Pavel Machek
2009-07-14 6:57 ` Michael Tokarev
2009-07-14 9:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A00264C.3020004@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.