All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm920t kgdb serial support
Date: Tue, 05 May 2009 14:30:39 -0500	[thread overview]
Message-ID: <4A0093DF.3070500@freescale.com> (raw)
In-Reply-To: <20090505212121.82375u7m9i47arok@webmail.igi.cnr.it>

barbalace at igi.cnr.it wrote:
> This patch add kgdb to ARM920T cpus (full support to s3c2440).
> The patch lets debugging remote ARM targets using the serial
> line and GDB.
> 
> Signed-off-by: Antonio Barbalace <antonio.barbalace@igi.cnr.it>
> 
> diff -r -u u-boot/common/kgdb.c u-boot-UniPd-denx.de/common/kgdb.c
> --- u-boot/common/kgdb.c	2007-11-06 18:07:07.000000000 +0100
> +++ u-boot-UniPd-denx.de/common/kgdb.c	2009-05-05 18:44:25.000000000 +0200
> @@ -458,6 +458,7 @@
> 
>   			goto doexit;
> 
> +#ifdef _PPC

CONFIG_PPC -- and explain in a comment why this is powerpc-specific (and 
keep in mind that ARM and PowerPC are not the only possibilities), and 
what happens on other architectures if those commands are used.

> @@ -496,8 +497,13 @@
>   			} else {
>   				kgdb_error(KGDBERR_BADPARAMS);
>   			}
> +
> +		case 'q':
> +			if (!(strcmp(ptr, "Supported"))) {
> +				sprintf(remcomOutBuffer, "PacketSize=%d", BUFMAX);
> +			}
>   			break;

Explain what this change does -- what does it have to do with arm920t?

-Scott

  reply	other threads:[~2009-05-05 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 19:21 [U-Boot] [PATCH] arm920t kgdb serial support barbalace at igi.cnr.it
2009-05-05 19:30 ` Scott Wood [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-05-05 17:35 [U-Boot] PATCH " barbalace at igi.cnr.it
2009-05-05 18:53 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0093DF.3070500@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.