From: Yinghai Lu <yinghai@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>, linux-next@vger.kernel.org
Subject: Re: linux-next: pci tree build warning
Date: Wed, 06 May 2009 00:21:20 -0700 [thread overview]
Message-ID: <4A013A70.30101@kernel.org> (raw)
In-Reply-To: <20090506143007.c0ef2340.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Jesse,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
>
> drivers/pci/probe.c: In function '__pci_read_base':
> drivers/pci/probe.c:196: warning: large integer implicitly truncated to unsigned type
>
> Probably introduced by commit 82160fd142cdf6956a677120426bf5baefcc7cf9
> ("PCI/x86: don't assume prefetchable ranges are 64bit").
>
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -193,7 +193,7 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
res->flags |= pci_calc_resource_flags(l) | IORESOURCE_SIZEALIGN;
if (type == pci_bar_io) {
l &= PCI_BASE_ADDRESS_IO_MASK;
- mask = PCI_BASE_ADDRESS_IO_MASK & 0xffff;
+ mask = PCI_BASE_ADDRESS_IO_MASK & IO_SPACE_LIMIT;
and
for x86:
#define IO_SPACE_LIMIT 0xffff
for powerpc
arch/powerpc/include/asm/io.h:#define IO_SPACE_LIMIT ~(0UL)
maybe we need to change back that line...
YH
next prev parent reply other threads:[~2009-05-06 7:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 4:30 linux-next: pci tree build warning Stephen Rothwell
2009-05-06 7:21 ` Yinghai Lu [this message]
2009-05-06 16:24 ` linux-next: IO BAR sizing warning Jesse Barnes
2009-05-06 17:41 ` Wilcox, Matthew R
2009-05-06 18:00 ` Jesse Barnes
2009-05-06 18:03 ` Wilcox, Matthew R
2009-06-03 6:49 ` Stephen Rothwell
2009-06-11 19:07 ` Jesse Barnes
2009-06-11 21:39 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-10-08 4:27 linux-next: pci tree build warning Stephen Rothwell
2009-08-13 2:47 Stephen Rothwell
2009-08-13 3:32 ` Benjamin Herrenschmidt
2009-08-13 8:38 ` Vignatti Tiago (Nokia-D/Helsinki)
2009-02-18 6:31 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A013A70.30101@kernel.org \
--to=yinghai@kernel.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.