All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: flow start_time
Date: Wed, 06 May 2009 15:47:04 +0400	[thread overview]
Message-ID: <4A0178B8.3040706@msgid.tls.msk.ru> (raw)
In-Reply-To: <4A0173CF.6080505@netfilter.org>

Pablo Neira Ayuso wrote:
[]
>> For nowadays tools, in case we've seen "new" but not "remove" event,
>> that connection will be in our hash table sorta forever (ok, till
>> restart).  Which is, I think, worse than not logging it at all (it
>> will not be logged anyway).
>>
>> Basically, I don't see such a case (lost "remove" event) as valid.
> 
> I have a couple of patches here that I'm still working on it here to
> avoid "remove" event loss. It should be ready for review once the
> nf-next-2.6 tree is open.

Well, I didn't know it can occur to start with :)  But it's good to
know it's almost fixed -- thanks!

> To know when a flow starts and avoid the problem of "new" event loss. I
> think that we can still add a conntrack extension to store the start
> time. I think that's enough, right?

It is _exactly_ what I'm talking/asking about.  To say - Does anyone
have an objection to that?

Which time to use is entirely another question.  Should it be 'ticks'
or 'jiffies' or like time(2)/gettimeofday(2) with all the fun stuff
about system time resets etc.....  Oh well.

Thanks.

/mjt

      reply	other threads:[~2009-05-06 11:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 15:32 flow start_time Michael Tokarev
2009-05-05 13:58 ` Patrick McHardy
2009-05-06 11:07   ` Michael Tokarev
2009-05-06 11:26     ` Pablo Neira Ayuso
2009-05-06 11:47       ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0178B8.3040706@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.