From: Pablo Neira Ayuso <pablo@netfilter.org>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/4] conntrack event subsystem updates for 2.6.31
Date: Wed, 06 May 2009 15:36:06 +0200 [thread overview]
Message-ID: <4A019246.4070001@netfilter.org> (raw)
In-Reply-To: <20090502141522.8067.436.stgit@Decadence>
Pablo Neira Ayuso wrote:
> Hi Patrick,
>
> This is the first bunch of patches oriented to the event caching
> system, I still have a couple more here but I'm still getting them
> into shape.
I noticed a "scheduling while atomic" problem in the event caching
"replace notify chain by function pointer" patch. It seems that
gfp_any(), which is used by nfnetlink_send(), returns GFP_KERNEL inside
a RCU read-side lock section, that's invalid. Moreover, this triggers a
backtrace when using very small buffers and making lots of requests from
user-context (we hit schedule() due to __GFP_WAIT in the netlink code).
Patrick, just to let you know in case that you look at these patches. I
have fixed this here. I'll resend these patches once nf-next-2.6 is open.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
prev parent reply other threads:[~2009-05-06 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 14:18 [PATCH 0/4] conntrack event subsystem updates for 2.6.31 Pablo Neira Ayuso
2009-05-02 14:18 ` [PATCH 1/4] netfilter: conntrack: don't report events on module removal Pablo Neira Ayuso
2009-05-02 14:19 ` [PATCH 2/4] netfilter: conntrack: remove events flags from userspace exposed file Pablo Neira Ayuso
2009-05-02 14:19 ` [PATCH 3/4] netfilter: conntrack: simplify event caching system Pablo Neira Ayuso
2009-05-02 14:20 ` [PATCH 4/4] netfilter: conntrack: replace notify chain by function pointer Pablo Neira Ayuso
2009-05-06 13:36 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A019246.4070001@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.