All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Gardiner <BenGardiner@nanometrics.ca>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] remove dynamic libiptc.so from iptables-static
Date: Wed, 06 May 2009 15:15:08 +0000	[thread overview]
Message-ID: <4A01A97C.6040305@nanometrics.ca> (raw)

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]

I was building iptables-static from 1.4.3.2 and I noticed that ldd 
reported libiptc.so was a dependency; I was using gcc 4.0.1 for ppc 
cross compile -- but I don't think the toolchain is the cause. I was 
able to get iptables-static to depend only on libm and libc with the 
following patch (made against the 1.4.3.2 dist, but applies clean to svn 
trunk). I hope you will consider it for inclusion in the next release.

Thanks,
Ben Gardiner

diff --git a/Makefile.am b/Makefile.am
index fd99098..80ee250 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,7 +15,12 @@ lib_LTLIBRARIES =
 
 # libiptc
 lib_LTLIBRARIES           += libiptc/libiptc.la
-libiptc_libiptc_la_SOURCES = libiptc/libip4tc.c libiptc/libip6tc.c
+if ENABLE_IPV4
+libiptc_libiptc_la_SOURCES = libiptc/libip4tc.c
+endif
+if ENABLE_IPV6
+libiptc_libiptc_la_SOURCES = libiptc/libip6tc.c
+endif
 libiptc_libiptc_la_LDFLAGS = -version-info 0:0:0
 
 lib_LTLIBRARIES      += libxtables.la
@@ -44,10 +49,10 @@ iptables_save_SOURCES     = iptables-save.c iptables.c
 iptables_save_LDFLAGS     = ${iptables_LDFLAGS}
 iptables_save_LDADD       = ${iptables_LDADD}
 
-# iptables-multi, semi-static
-iptables_static_SOURCES   = ${iptables_multi_SOURCES} xtables.c
+# iptables-static
+iptables_static_SOURCES   = ${iptables_multi_SOURCES} xtables.c 
${libiptc_libiptc_la_SOURCES}
 iptables_static_CFLAGS    = ${iptables_multi_CFLAGS} -DNO_SHARED_LIBS=1
-iptables_static_LDADD     = libiptc/libiptc.la extensions/libext4.a -lm
+iptables_static_LDADD     = extensions/libext4.a -lm
 
 iptables_xml_SOURCES      = iptables-xml.c

[-- Attachment #2: BenGardiner.vcf --]
[-- Type: text/x-vcard, Size: 320 bytes --]

begin:vcard
fn:Ben Gardiner
n:Gardiner;Ben
org:Nanometrics Seismological Instruments;Software R&D
adr:;;250 Herzberg Rd.;Kanata;ON;K2K 2A1;Canada
email;internet:bengardiner@nanometrics.ca
title:M.Sc. Eng.
tel;work:613 592 6776 x239
tel;fax:613 592 5929
x-mozilla-html:FALSE
url:www.nanometrics.ca
version:2.1
end:vcard


             reply	other threads:[~2009-05-06 15:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 15:15 Ben Gardiner [this message]
2009-06-01 11:30 ` [PATCH] remove dynamic libiptc.so from iptables-static Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A01A97C.6040305@nanometrics.ca \
    --to=bengardiner@nanometrics.ca \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.