From: Michael Raskin <7c6f434c@mail.ru>
To: Edward Shishkin <edward.shishkin@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [BUG] fallocate behavior when crossing end-of-file
Date: Thu, 07 May 2009 01:07:18 +0400 [thread overview]
Message-ID: <4A01FC06.80703@mail.ru> (raw)
In-Reply-To: <4A01AE6E.1050400@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Edward Shishkin wrote:
>> <<<
>> If the offset+ len is beyond the current file size, then
>> posix_fallocate() shall adjust the file size to offset+ len. Otherwise,
>> the file size shall not be changed.
>>
>
> fallocate (2) is something different from posix_fallocate:
>
> "...This default behavior closely resembles the behavior
> of the posix_fallocate(3) library function, and is intended
> as a method of optimally implementing that function."
If you overincrement file size counter, the only way for glibc to
correctly implement is to ftruncate after fallocate . It doesn't look
like an optimal implementation of posix_fallocate (2 system calls). It
also doesn't look like something glibc would do. It currently doesn't.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iQEcBAEBAgAGBQJKAfwBAAoJEE6tnN0aWvw3NQAH/2XFOZE/9MBAxySxOyNY9Gft
ttotQ4+g7SuKX47tQzskcWde3qbofEYzrsF/ADebjczEwbiKcZaJwlLzqL1X6siC
IWzBS8hIWbbKkyF2erQJP3QZEJq/IwRCK6bOj8EJckGJ6q6tLCIasXGs+GOAjhrB
1NWjDfprXP5M4s1xvG9KRH4Lo38Bz4/5w7ZGqGuXOy+M21ZHim+o9Tbkp7LaV9KP
OHqxgXV6tpHHv+Ai16cR1cJzY8XAIZ6EsL4lfpw7nZGlgRC+snccNdyoN3MltFOG
fbqIxrcPb8jL+3sAY+F1EK9oOKrCjQhY8VKxksy++M8+uP7OmgRiRkPyNewbYlw=
=fY9t
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2009-05-06 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 13:03 [BUG] fallocate behavior when crossing end-of-file Raskin Michael
2009-05-06 14:59 ` Edward Shishkin
2009-05-06 15:10 ` Chris Mason
2009-05-06 15:12 ` Michael Raskin
2009-05-06 15:36 ` Edward Shishkin
2009-05-06 21:07 ` Michael Raskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A01FC06.80703@mail.ru \
--to=7c6f434c@mail.ru \
--cc=edward.shishkin@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.