Re: [PATCH] Invalid request_limit unnoticed?

[Brian King <brking@linux.vnet.ibm.com>]

Acked by: Brian King <brking@linux.vnet.ibm.com>

Roel Kluin wrote:
> Remove redundant test on unsigned.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> 
> ---
> Maybe a different test is required? 
> 
> To see that it is unsigned:
> 
> git grep -E -n "(req_lim_delta|__be32;$)"
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index c9aa761..8d3925f 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -910,9 +910,6 @@ static void login_rsp(struct srp_event_struct *evt_struct)
> 
>  	dev_info(hostdata->dev, "SRP_LOGIN succeeded\n");
> 
> -	if (evt_struct->xfer_iu->srp.login_rsp.req_lim_delta < 0)
> -		dev_err(hostdata->dev, "Invalid request_limit.\n");
> -
>  	/* Now we know what the real request-limit is.
>  	 * This value is set rather than added to request_limit because
>  	 * request_limit could have been set to -1 by this client.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center