From mboxrd@z Thu Jan 1 00:00:00 1970 From: "IKEDA, Munehiro" Subject: Re: [PATCH 18/18] io-controller: Debug hierarchical IO scheduling Date: Wed, 06 May 2009 19:01:30 -0400 Message-ID: <4A0216CA.3070106@ds.jp.nec.com> References: <1241553525-28095-1-git-send-email-vgoyal@redhat.com> <1241553525-28095-19-git-send-email-vgoyal@redhat.com> <4A0203DB.1090809@ds.jp.nec.com> <20090506215833.GK8180@redhat.com> <4A020CD5.2000308@ds.jp.nec.com> <20090506222458.GM8180@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090506222458.GM8180-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Vivek Goyal Cc: dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org, jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org List-Id: containers.vger.kernel.org Vivek Goyal wrote: > On Wed, May 06, 2009 at 06:19:01PM -0400, IKEDA, Munehiro wrote: >> Hi, >> >> Vivek Goyal wrote: >>> Hi Ikeda, >>> >>> I think there is some issue with applying the patch. I think you have >>> forgotten to apply following patch and that's why seeing all the issues. >>> >>> "io-controller: Export disk time used and nr sectors dipatched through >>> cgroups" >>> >>> This patch changes elv_ioq_served() at the same time introduced additional >>> field of total_sector_service etc. >>> >>> Thanks >>> Vivek >> Oh! you are right. I missed it because it is out of the >> thread... > > That's strange. In "mutt" I see this patch (patch number 7) as part of the > thread. Which mail client are you using. Not sure if it is mail client > specific thing or some issue with my way of using "git-send-email". > > Thanks > Vivek I'm using a little bit old Thunderbird (ver.2.0.0). I believe you are completely doing right because In-Reply-To in the mail header of patch #7 correctly points the first mail. The mail of patch #7 seems to have slightly earlier time stamp than the first mail. Poor Thunderbird might be confused by this, in my wild guess. Sorry for confusing you. -- IKEDA, Munehiro NEC Corporation of America m-ikeda-MDRzhb/z0dd8UrSeD/g0lQ@public.gmane.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761115AbZEFXEl (ORCPT ); Wed, 6 May 2009 19:04:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752447AbZEFXEc (ORCPT ); Wed, 6 May 2009 19:04:32 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42155 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbZEFXEb (ORCPT ); Wed, 6 May 2009 19:04:31 -0400 Message-ID: <4A0216CA.3070106@ds.jp.nec.com> Date: Wed, 06 May 2009 19:01:30 -0400 From: "IKEDA, Munehiro" User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Vivek Goyal CC: nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, jens.axboe@oracle.com, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, guijianfeng@cn.fujitsu.com, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, righi.andrea@gmail.com, agk@redhat.com, dm-devel@redhat.com, snitzer@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH 18/18] io-controller: Debug hierarchical IO scheduling References: <1241553525-28095-1-git-send-email-vgoyal@redhat.com> <1241553525-28095-19-git-send-email-vgoyal@redhat.com> <4A0203DB.1090809@ds.jp.nec.com> <20090506215833.GK8180@redhat.com> <4A020CD5.2000308@ds.jp.nec.com> <20090506222458.GM8180@redhat.com> In-Reply-To: <20090506222458.GM8180@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vivek Goyal wrote: > On Wed, May 06, 2009 at 06:19:01PM -0400, IKEDA, Munehiro wrote: >> Hi, >> >> Vivek Goyal wrote: >>> Hi Ikeda, >>> >>> I think there is some issue with applying the patch. I think you have >>> forgotten to apply following patch and that's why seeing all the issues. >>> >>> "io-controller: Export disk time used and nr sectors dipatched through >>> cgroups" >>> >>> This patch changes elv_ioq_served() at the same time introduced additional >>> field of total_sector_service etc. >>> >>> Thanks >>> Vivek >> Oh! you are right. I missed it because it is out of the >> thread... > > That's strange. In "mutt" I see this patch (patch number 7) as part of the > thread. Which mail client are you using. Not sure if it is mail client > specific thing or some issue with my way of using "git-send-email". > > Thanks > Vivek I'm using a little bit old Thunderbird (ver.2.0.0). I believe you are completely doing right because In-Reply-To in the mail header of patch #7 correctly points the first mail. The mail of patch #7 seems to have slightly earlier time stamp than the first mail. Poor Thunderbird might be confused by this, in my wild guess. Sorry for confusing you. -- IKEDA, Munehiro NEC Corporation of America m-ikeda@ds.jp.nec.com