From: Robert Hancock <hancockrwd@gmail.com>
To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, Ward Vandewege <ward@gnu.org>
Subject: Re: [PATCH] libata: Add multi-count transfer debugging
Date: Wed, 06 May 2009 23:02:47 -0600 [thread overview]
Message-ID: <4A026B77.2000801@gmail.com> (raw)
In-Reply-To: <4A01946E.1020300@gmx.net>
Carl-Daniel Hailfinger wrote:
> On my Asus M2A-VM (SB600) board, the SATA disks use multi-count
> transfers only with some BIOS variants.
> Dumping the relevant config words helps debugging a lot.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>
> --- a/drivers/ata/libata-core.c 2009-05-06 14:24:32.000000000 +0200
> +++ b/drivers/ata/libata-core.c 2009-05-06 15:27:06.000000000 +0200
> @@ -2390,11 +2390,11 @@
> /* print device capabilities */
> if (ata_msg_probe(ap))
> ata_dev_printk(dev, KERN_DEBUG,
> - "%s: cfg 49:%04x 82:%04x 83:%04x 84:%04x "
> - "85:%04x 86:%04x 87:%04x 88:%04x\n",
> + "%s: cfg 47:%04x 49:%04x 59:%04x 82:%04x 83:%04x"
> + " 84:%04x 85:%04x 86:%04x 87:%04x 88:%04x\n",
> __func__,
> - id[49], id[82], id[83], id[84],
> - id[85], id[86], id[87], id[88]);
> + id[47], id[49], id[59], id[82], id[83],
> + id[84], id[85], id[86], id[87], id[88]);
>
> /* initialize to-be-configured parameters */
> dev->flags &= ~ATA_DFLAG_CFG_MASK;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Keep in mind that multi-count transfers are only meaningful for PIO
read/write commands (it controls the number of sectors transferred for
each DRQ assertion), which would only be used if the device didn't
support DMA - unlikely for SATA..
prev parent reply other threads:[~2009-05-07 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 13:45 [PATCH] libata: Add multi-count transfer debugging Carl-Daniel Hailfinger
2009-05-07 5:02 ` Robert Hancock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A026B77.2000801@gmail.com \
--to=hancockrwd@gmail.com \
--cc=c-d.hailfinger.devel.2006@gmx.net \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=ward@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.