From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH 08/12] mpc5121: Added I2C support. Date: Thu, 07 May 2009 08:36:50 +0200 Message-ID: <4A028182.3040107@grandegger.com> References: <1241640919-4650-1-git-send-email-wd@denx.de> <1241640919-4650-9-git-send-email-wd@denx.de> <20090506221908.3927583420E8@gemini.denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: Wolfgang Denk , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Piotr Ziecik , Detlev Zundel , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Grant Likely wrote: > On Wed, May 6, 2009 at 4:51 PM, Grant Likely wrote: >> On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk wrote: >>> Dear Grant Likely, >>> >>> In message you wrote: >>>> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk wrote: >>>>> From: Piotr Ziecik >>>>> >>>>> - Enabled I2C interrupts on MPC5121. >>>>> - Updated Kconfig for i2c-mpc driver. >>>> I think this workaround belongs in the driver itself. >>> Sorry, I don't get it. Which workaround? What exactly should I change? >> Sorry, I misread the patch. Never mind. > > Actually, on 3rd reading, I think my first impression was correct > (even if I was wrong about it being a workaround). This code in > mpc512x_init_i2c() is only relevant for i2c busses (it isn't shared > with any other drivers). Therefore, it belongs with the i2c bus > itself. It does not belong in platform code. Right. Furthermore, the i2c-mpc.c should be extened to support bus speed setting for the MPC512x, which has been merged recently (see commit id f2bd5efe). Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by ozlabs.org (Postfix) with ESMTP id B2E85DDDF0 for ; Thu, 7 May 2009 16:36:57 +1000 (EST) Message-ID: <4A028182.3040107@grandegger.com> Date: Thu, 07 May 2009 08:36:50 +0200 From: Wolfgang Grandegger MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH 08/12] mpc5121: Added I2C support. References: <1241640919-4650-1-git-send-email-wd@denx.de> <1241640919-4650-9-git-send-email-wd@denx.de> <20090506221908.3927583420E8@gemini.denx.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-i2c@vger.kernel.org, linuxppc-dev@ozlabs.org, Wolfgang Denk , Detlev Zundel , Piotr Ziecik List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Grant Likely wrote: > On Wed, May 6, 2009 at 4:51 PM, Grant Likely wrote: >> On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk wrote: >>> Dear Grant Likely, >>> >>> In message you wrote: >>>> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk wrote: >>>>> From: Piotr Ziecik >>>>> >>>>> - Enabled I2C interrupts on MPC5121. >>>>> - Updated Kconfig for i2c-mpc driver. >>>> I think this workaround belongs in the driver itself. >>> Sorry, I don't get it. Which workaround? What exactly should I change? >> Sorry, I misread the patch. Never mind. > > Actually, on 3rd reading, I think my first impression was correct > (even if I was wrong about it being a workaround). This code in > mpc512x_init_i2c() is only relevant for i2c busses (it isn't shared > with any other drivers). Therefore, it belongs with the i2c bus > itself. It does not belong in platform code. Right. Furthermore, the i2c-mpc.c should be extened to support bus speed setting for the MPC512x, which has been merged recently (see commit id f2bd5efe). Wolfgang.