From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Date: Thu, 07 May 2009 09:35:57 +0000 Subject: Re: [patch] fix - do not build blobs when blobs are not needed Message-Id: <4A02AB7D.5000509@sgi.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------060002040905000805030307" List-Id: References: <4A02A1BA.5020003@sgi.com> In-Reply-To: <4A02A1BA.5020003@sgi.com> To: kvm-ia64@vger.kernel.org This is a multi-part message in MIME format. --------------060002040905000805030307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > Seems a bit heavy handed. blobs != extboot. > > How about instead: > > build-targets-x86 = kvm/extboot > > all: $(build-targets-$(ARCH)) > > (or something similar that builds) There's no problem that cannot be fixed by applying an appropriately large hammer .... :-) This one works for me. Jes --------------060002040905000805030307 Content-Type: text/x-patch; name="0009-qemu-kvm-ia64-defaults.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0009-qemu-kvm-ia64-defaults.patch" Do not try to build extboot on non-x86. Signed-off-by: Jes Sorensen --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: qemu-kvm/Makefile =================================================================== --- qemu-kvm.orig/Makefile +++ qemu-kvm/Makefile @@ -419,7 +419,10 @@ .PHONY: kvm/extboot -all: kvm/extboot +build-targets-x86 = kvm/extboot +build-targets-ia64 = + +all: $(build-targets-$(ARCH)) kvm/extboot: $(MAKE) -C $@ --------------060002040905000805030307-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [patch] fix - do not build blobs when blobs are not needed Date: Thu, 07 May 2009 11:35:57 +0200 Message-ID: <4A02AB7D.5000509@sgi.com> References: <4A02A1BA.5020003@sgi.com> <4A02A952.60204@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060002040905000805030307" Cc: "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from relay1.sgi.com ([192.48.179.29]:46236 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756660AbZEGJgE (ORCPT ); Thu, 7 May 2009 05:36:04 -0400 In-Reply-To: <4A02A952.60204@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------060002040905000805030307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > Seems a bit heavy handed. blobs != extboot. > > How about instead: > > build-targets-x86 = kvm/extboot > > all: $(build-targets-$(ARCH)) > > (or something similar that builds) There's no problem that cannot be fixed by applying an appropriately large hammer .... :-) This one works for me. Jes --------------060002040905000805030307 Content-Type: text/x-patch; name="0009-qemu-kvm-ia64-defaults.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0009-qemu-kvm-ia64-defaults.patch" Do not try to build extboot on non-x86. Signed-off-by: Jes Sorensen --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: qemu-kvm/Makefile =================================================================== --- qemu-kvm.orig/Makefile +++ qemu-kvm/Makefile @@ -419,7 +419,10 @@ .PHONY: kvm/extboot -all: kvm/extboot +build-targets-x86 = kvm/extboot +build-targets-ia64 = + +all: $(build-targets-$(ARCH)) kvm/extboot: $(MAKE) -C $@ --------------060002040905000805030307--