From: Eric Sandeen <sandeen@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] vfs: Add BUG_ON for delayed and unwritten extents in submit_bh
Date: Thu, 07 May 2009 10:37:24 -0500 [thread overview]
Message-ID: <4A030034.50504@redhat.com> (raw)
In-Reply-To: <1241692770-22547-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Aneesh Kumar K.V wrote:
> We should not do submit_bh for delayed and unwritten extents. So
> add a BUG_ON on them.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Makes sense to me, once we get our own house in order. :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/buffer.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index b3e5be7..ec480c8 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2931,6 +2931,8 @@ int submit_bh(int rw, struct buffer_head * bh)
> BUG_ON(!buffer_locked(bh));
> BUG_ON(!buffer_mapped(bh));
> BUG_ON(!bh->b_end_io);
> + BUG_ON(buffer_delay(bh));
> + BUG_ON(buffer_unwritten(bh));
>
> /*
> * Mask in barrier bit for a write (could be either a WRITE or a
next prev parent reply other threads:[~2009-05-07 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 10:39 [PATCH 1/3] ext4: Properly initialize the buffer_head state Aneesh Kumar K.V
2009-05-07 10:39 ` [PATCH 2/3] ext4: Clear the unwritten buffer_head flag properly Aneesh Kumar K.V
2009-05-07 10:39 ` [PATCH 3/3] vfs: Add BUG_ON for delayed and unwritten extents in submit_bh Aneesh Kumar K.V
2009-05-07 15:37 ` Eric Sandeen [this message]
2009-05-12 3:17 ` Theodore Tso
2009-05-12 4:52 ` [PATCH 3/3] vfs: Add BUG_ON for delayed and unwritten extentsin submit_bh Aneesh Kumar K.V
2009-05-12 13:25 ` Eric Sandeen
2009-05-07 15:36 ` [PATCH 2/3] ext4: Clear the unwritten buffer_head flag properly Eric Sandeen
2009-05-08 8:12 ` Aneesh Kumar K.V
2009-05-12 3:08 ` Theodore Tso
2009-05-12 4:46 ` Aneesh Kumar K.V
2009-05-13 18:56 ` Eric Sandeen
2009-05-13 22:28 ` Theodore Tso
2009-05-14 6:00 ` Aneesh Kumar K.V
2009-05-14 5:40 ` Aneesh Kumar K.V
2009-05-14 13:14 ` Theodore Tso
2009-05-07 15:20 ` [PATCH 1/3] ext4: Properly initialize the buffer_head state Eric Sandeen
2009-05-10 23:57 ` Theodore Tso
2009-05-11 9:24 ` Aneesh Kumar K.V
2009-05-11 11:31 ` Theodore Tso
2009-05-11 14:49 ` Eric Sandeen
2009-05-12 3:17 ` Theodore Tso
2009-05-12 4:47 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A030034.50504@redhat.com \
--to=sandeen@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.