All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfstests 042: point xfs_fsr right at the fragmented file
Date: Thu, 07 May 2009 20:12:29 -0500	[thread overview]
Message-ID: <4A0386FD.7000108@sandeen.net> (raw)

Somehow 042 as it stands isn't actually defragging the fragmented
file we created (see 042.full post-run)

Probably need to look into that as well, but for now this should
make the call to fsr actually _do_ something.

This has let 2 fsr bugs slip through qa in the past few months.  :(

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/042 b/042
index 6628040..1ad81e4 100755
--- a/042
+++ b/042
@@ -114,7 +114,7 @@ _do "sum $SCRATCH_MNT/fragmented >$tmp.sum1"
 _do "Remove other files" "rm -rf $SCRATCH_MNT/{pad,hole*}"
 
 # defragment
-_do "Run xfs_fsr on filesystem" "$XFS_FSR_PROG -v $SCRATCH_DEV"
+_do "Run xfs_fsr on filesystem" "$XFS_FSR_PROG -v $SCRATCH_MNT/fragmented"
 _do "xfs_bmap -v $SCRATCH_MNT/fragmented"
 _do "Check 4k files" "src/fill2fs_check $tmp.manifest"
 


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2009-05-08  1:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08  1:12 Eric Sandeen [this message]
2009-05-08  6:26 ` [PATCH] xfstests 042: point xfs_fsr right at the fragmented file Christoph Hellwig
2009-05-08 12:43   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0386FD.7000108@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.