From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gui Jianfeng Subject: Re: [PATCH 17/18] io-controller: IO group refcounting support Date: Fri, 08 May 2009 10:59:31 +0800 Message-ID: <4A03A013.9000405@cn.fujitsu.com> References: <1241553525-28095-1-git-send-email-vgoyal@redhat.com> <1241553525-28095-18-git-send-email-vgoyal@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1241553525-28095-18-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Vivek Goyal Cc: dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org, jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: containers.vger.kernel.org Vivek Goyal wrote: ... > > - BUG_ON(!RB_EMPTY_ROOT(&st->active)); > - BUG_ON(!RB_EMPTY_ROOT(&st->idle)); > } > > - BUG_ON(iog->sched_data.next_active != NULL); > - BUG_ON(iog->sched_data.active_entity != NULL); > - BUG_ON(entity->tree != NULL); > + /* Drop iocg reference on io group */ We'd better to reset iog->iocg_id here since the cgroup is going to destroy. > + elv_put_iog(iog); > } > > -/** -- Regards Gui Jianfeng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764164AbZEHDFy (ORCPT ); Thu, 7 May 2009 23:05:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763504AbZEHDAa (ORCPT ); Thu, 7 May 2009 23:00:30 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:50442 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1763496AbZEHDA2 (ORCPT ); Thu, 7 May 2009 23:00:28 -0400 Message-ID: <4A03A013.9000405@cn.fujitsu.com> Date: Fri, 08 May 2009 10:59:31 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Vivek Goyal CC: nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, jens.axboe@oracle.com, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, righi.andrea@gmail.com, agk@redhat.com, dm-devel@redhat.com, snitzer@redhat.com, m-ikeda@ds.jp.nec.com, akpm@linux-foundation.org Subject: Re: [PATCH 17/18] io-controller: IO group refcounting support References: <1241553525-28095-1-git-send-email-vgoyal@redhat.com> <1241553525-28095-18-git-send-email-vgoyal@redhat.com> In-Reply-To: <1241553525-28095-18-git-send-email-vgoyal@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vivek Goyal wrote: ... > > - BUG_ON(!RB_EMPTY_ROOT(&st->active)); > - BUG_ON(!RB_EMPTY_ROOT(&st->idle)); > } > > - BUG_ON(iog->sched_data.next_active != NULL); > - BUG_ON(iog->sched_data.active_entity != NULL); > - BUG_ON(entity->tree != NULL); > + /* Drop iocg reference on io group */ We'd better to reset iog->iocg_id here since the cgroup is going to destroy. > + elv_put_iog(iog); > } > > -/** -- Regards Gui Jianfeng