From: Jeremy Huddleston <jeremyhu@freedesktop.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] appletouch: Improved finger detection
Date: Thu, 07 May 2009 23:13:26 -0700 [thread overview]
Message-ID: <4A03CD86.4010402@freedesktop.org> (raw)
In-Reply-To: <20090508025839.GC30616@dtor-d630.eng.vmware.com>
Dmitry Torokhov wrote:
> HI Jeremy,
>
> On Tue, May 05, 2009 at 12:10:34PM -0700, Jeremy Huddleston wrote:
>> The appletouch driver is prone to reporting multiple fingers when only
>> one is
>> pressing. The appletouch driver queries an array of pressure sensors
>> and
>> counts local maxima in pressure to determine the number of fingers. It
>> just
>> does this on the raw values, so a data stream like:
>>
>> 0 100 250 300 299 300 250 100 0
>>
>> actually registers as 2 fingers.
>>
>> This patch updates the logic to ignore small dips in pressure that are
>> less
>> than the threshold.
>>
>
> Does it still detect 2 fingers as 2 fingers when they are held together?
>
Yes... and 3 when 3 are there. Before, it would frequently report 3
instead of 2 or 2 instead of 1. I have found the behavior with this
patch very reliable... the old behavior was not reliable for me (perhaps
due to a precision issue in hardware... or a dent in my finger).
next prev parent reply other threads:[~2009-05-08 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 19:10 [PATCH] appletouch: Improved finger detection Jeremy Huddleston
2009-05-08 2:59 ` Dmitry Torokhov
2009-05-08 6:13 ` Jeremy Huddleston [this message]
2009-06-01 7:35 ` Jeremy Huddleston
2009-06-02 11:29 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A03CD86.4010402@freedesktop.org \
--to=jeremyhu@freedesktop.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.