All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Matthias Andree <matthias.andree@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] To make GIT-VERSION-FILE, search for git more widely
Date: Fri, 08 May 2009 10:52:56 +0200	[thread overview]
Message-ID: <4A03F2E8.2020907@viscovery.net> (raw)
In-Reply-To: <op.utlq3vgx1e62zd@merlin.emma.line.org>

Matthias Andree schrieb:
> Am 08.05.2009, 02:05 Uhr, schrieb Junio C Hamano <gitster@pobox.com>:
>> Interesting.  I wonder if you need the change to the Makefile.
>>
>> As long as GIT-VERSION-GEN notices that you have a freshly built git
>> available (test -x) and uses it, falling back to whatever on the PATH, it
>> would not have to touch GIT-VERSION-FILE, no?
> 
> Hi Junio,
> 
> Makefile (+ GNU make) is the actual culprit and introduces this cycle,
> why do we want to leave Makefile - of all things - alone?

Because it is not necessary to change it?

With Junio's proposed change the following:

   $ make && PATH=/bin:/usr/bin make

builds only once[*], whereas previously it built twice.

[*] It still builds twice in git-gui, but I think that your original patch
wouldn't fix that, either.

-- Hannes

      parent reply	other threads:[~2009-05-08  8:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07  9:22 [PATCH v3] To make GIT-VERSION-FILE, search for git more widely Matthias Andree
2009-05-07 11:49 ` Michael J Gruber
2009-05-07 12:04   ` Matthias Andree
2009-05-07 12:09     ` Michael J Gruber
2009-05-07 12:12       ` Matthias Andree
2009-05-08  0:05 ` Junio C Hamano
2009-05-08  8:27   ` Matthias Andree
2009-05-08  8:41     ` Junio C Hamano
2009-05-08 11:09       ` Matthias Andree
2009-05-09 16:55         ` Junio C Hamano
2009-05-09 17:10           ` Francis Galiegue
2009-05-09 18:17           ` Matthias Andree
2009-05-13 12:17           ` Matthias Andree
2009-05-13 19:32             ` Junio C Hamano
2009-06-02 10:55               ` Nanako Shiraishi
2009-06-02 15:50                 ` Junio C Hamano
2009-06-02 18:35                   ` Johannes Sixt
2009-06-03  7:32                     ` Matthias Andree
2009-06-04  0:12                     ` [PATCH v4] " Matthias Andree
2009-06-04  5:18                     ` [PATCH v3] " Junio C Hamano
2009-06-04  8:35                       ` Matthias Andree
2009-05-08  8:52     ` Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A03F2E8.2020907@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=matthias.andree@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.