All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Don Slutz <Don.Slutz@SierraAtlantic.com>
Cc: Alex Riesen <raa.lkml@gmail.com>,
	Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Hannu Koivisto <azure@iki.fi>,
	git@vger.kernel.org
Subject: Re: Tests in Cygwin
Date: Fri, 08 May 2009 16:28:38 +0200	[thread overview]
Message-ID: <4A044196.7050106@viscovery.net> (raw)
In-Reply-To: <4A043F7E.5070702@SierraAtlantic.com>

Don Slutz schrieb:
> So which should we go with? foo2() which does the original way or foof()
> which allows you to use ',' and '+', and spaces?

I'd say take Junio's original proposal (that separates with spaces), but use

     for prerequisite in $*      # split args at spaces

(including the comment!) instead of merely

     for prerequisite

I can certainly live with the quoting at the call sites of
test_expect_success that is needed in the few cases where there is more
than one prerequisite.

-- Hannes

  reply	other threads:[~2009-05-08 14:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17  9:47 Tests in Cygwin Hannu Koivisto
2009-05-06 19:34 ` Don Slutz
2009-05-06 20:42   ` Junio C Hamano
2009-05-07  7:13     ` Johannes Sixt
2009-05-07 15:47       ` Don Slutz
2009-05-07 18:29         ` Don Slutz
2009-05-08  0:02         ` Junio C Hamano
2009-05-08  6:03           ` Johannes Sixt
2009-05-08  2:00         ` Jeff King
2009-05-08  6:02           ` Johannes Sixt
2009-05-08  6:41             ` Junio C Hamano
2009-05-08  9:28               ` Alex Riesen
2009-05-08 14:19                 ` Don Slutz
2009-05-08 14:28                   ` Johannes Sixt [this message]
2009-05-08 16:45                   ` Alex Riesen
2009-05-08  0:00       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A044196.7050106@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Don.Slutz@SierraAtlantic.com \
    --cc=azure@iki.fi \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.