Re: [Qemu-devel] [PATCH 00/11] Networking fixes and slirp enhancements

[Jan Kiszka <jan.kiszka@siemens.com>]

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> This series starts with four networking-related fixes and then focuses
>> on a grand refactoring of the slirp user space IP stack configuration.
>>
>> The major contribution is that the virtual IP addresses used by slirp
>> can now be (almost) freely configured. This enables sophisticated
>> virtual network setups, specifically with guests that depends on
>> specific addresses.
>>
>> Find this series also at git://git.kiszka.org/qemu.git queues/net
>>
>> Jan Kiszka (11):
>>       net: Don't deliver to disabled interfaces in qemu_sendv_packet
>>       net: Fix and improved ordered packet delivery
>>       slirp: Avoid zombie processes after fork_exec
>>       net: Real fix for check_params users
>>       net: Improve parameter error reporting
>>       slirp: Reorder initialization
>>       Introduce get_next_param_value
>>       slirp: Move smb, redir, tftp and bootp parameters and -net channel
>>       slirp: Rework internal configuration
>>       slirp: Rework external configuration interface
>>       slirp: Bind support for host forwarding rules
>>   
> 
> With this series applied, I get:
> 
>  CC    slirp/cksum.o
> In file included from /home/anthony/git/qemu/slirp/slirp.h:216,
>                 from /home/anthony/git/qemu/slirp/cksum.c:34:
> /home/anthony/git/qemu/slirp/main.h:51: error: ‘PATH_MAX’ undeclared
> here (not in a function)
> make: *** [slirp/cksum.o] Error 1

Hmpf.

As I can't reproduce here: Does this add-on patch make it build?

diff --git a/slirp/main.h b/slirp/main.h
index 537c145..44f649a 100644
--- a/slirp/main.h
+++ b/slirp/main.h
@@ -9,6 +9,8 @@
 #include <sys/select.h>
 #endif
 
+#include <limit.h>
+
 #define TOWRITEMAX 512
 
 extern struct timeval tt;


Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux