All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Jens Axboe <Jens.Axboe@oracle.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Jeff Garzik <jeff@garzik.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	open-osd mailing-list <osd-dev@open-osd.org>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [patchset 0/4] osd: Stop usage of blk_rq_append_bio
Date: Sat, 09 May 2009 17:12:58 +0900	[thread overview]
Message-ID: <4A053B0A.9010501@kernel.org> (raw)
In-Reply-To: <4A0307F4.50205@panasas.com>

Boaz Harrosh wrote:
> Osd library needs to submit pre-allocated bios, form several sources.
> osdblk exofs and pNFS-layout driver all have prepared bios for IO submission.
> On top of that the osd library needs to append additional segments to the
> IO memory, for get/set attributes and more.
> 
> All these are done today by use of a temporary hack - blk_rq_append_bio.
> This is bad on few accounts.
> 1. blk_rq_append_bio was not meant to be exported and is very specific to its users.
> 2. blk_rq_append_bio does not support chained bios.
> 3. blk_rq_append_bio does not bounce the bio and therefore current osd implementation
>    has a bug.
> 
> The proposed solution adds two new fixtures to the block layer, and a corresponding
> fixing patch to osd. These are:
> 
> [PATCH 1/4] allow blk_rq_map_kern to append to requests

blk_rq_map_kern() part of modification looks good to me.

Thanks.

-- 
tejun

  parent reply	other threads:[~2009-05-09  8:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 16:10 [patchset 0/4] osd: Stop usage of blk_rq_append_bio Boaz Harrosh
2009-05-07 16:12 ` [PATCH 1/4] allow blk_rq_map_kern to append to requests Boaz Harrosh
2009-05-07 16:14 ` [PATCH 2/4] libosd: Use new blk_rq_map_kern Boaz Harrosh
2009-05-07 16:16 ` [RFC 3/4] New blk_make_request(), takes bio, returns a request Boaz Harrosh
2009-05-07 16:18 ` [RFC 4/4] libosd: Use of new blk_make_request Boaz Harrosh
2009-05-09  7:36 ` [patchset 0/4] osd: Stop usage of blk_rq_append_bio Jeff Garzik
2009-05-09  8:12 ` Tejun Heo [this message]
2009-05-12 11:25 ` Jens Axboe
2009-05-13 14:28   ` Boaz Harrosh
2009-05-13 14:36     ` Boaz Harrosh
2009-05-13 14:47       ` James Bottomley
2009-05-14 14:53         ` Boaz Harrosh
2009-05-14 15:35           ` James Bottomley
2009-05-14 16:11             ` Boaz Harrosh
2009-05-14 16:39               ` Boaz Harrosh
2009-05-17  8:24                 ` Boaz Harrosh
2009-05-14 16:46               ` James Bottomley
2009-05-13 14:52     ` Stephen Rothwell
2009-05-13 15:01       ` Boaz Harrosh
2009-05-13 15:13       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A053B0A.9010501@kernel.org \
    --to=tj@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Jens.Axboe@oracle.com \
    --cc=bharrosh@panasas.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jeff@garzik.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=osd-dev@open-osd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.