From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Greg KH <greg@kroah.com>, Eric Valette <eric.valette@free.fr>,
Hin-Tak Leung <hintak.leung@gmail.com>,
linux-wireless@vger.kernel.org,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFT] rtl8187: use DMA-aware buffers with usb_control_msg
Date: Sat, 09 May 2009 16:24:21 -0500 [thread overview]
Message-ID: <4A05F485.4080303@lwfinger.net> (raw)
In-Reply-To: <20090509155013.GA21763@tuxdriver.com>
John W. Linville wrote:
>
> Yeah, I don't like the original version either. Even if the kmalloc's
> aren't a big performance hit, the failure path sucks. I've included a
> new version below, but unfortunately I haven't had a chance to test it.
> Please give it a try if you get a chance?
This one tests just fine here running on the latest pull of wireless testing
(v2.6.30-rc4-22732-gd879ac6). I think there is a leak of priv->io_dmabuf when
the driver is unloaded, and kfree(priv->io_dmabuf) should be added to
rtl8187_disconnect(). Otherwise ACK.
Larry
next prev parent reply other threads:[~2009-05-09 21:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 15:36 DMA debug trace pointing to rtl8187 Eric Valette
2009-05-06 4:30 ` FUJITA Tomonori
2009-05-06 5:21 ` Greg KH
2009-05-06 6:35 ` Eric Valette
2009-05-06 6:45 ` Greg KH
2009-05-06 18:02 ` [RFT] rtl8187: use DMA-aware buffers with usb_control_msg John W. Linville
2009-05-08 23:20 ` Hin-Tak Leung
2009-05-09 9:38 ` Eric Valette
2009-05-09 13:57 ` Greg KH
2009-05-09 15:50 ` John W. Linville
2009-05-09 16:35 ` Greg KH
2009-05-09 21:24 ` Larry Finger [this message]
2009-05-11 13:20 ` John W. Linville
2009-05-11 22:23 ` Hin-Tak Leung
2009-05-11 22:23 ` Hin-Tak Leung
2009-05-06 18:03 ` DMA debug trace pointing to rtl8187 John W. Linville
2009-05-09 17:29 ` Larry Finger
2009-05-09 17:46 ` Eric Valette
2009-05-09 19:22 ` Eric Valette
2009-05-09 19:29 ` Greg KH
2009-05-09 20:19 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A05F485.4080303@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=eric.valette@free.fr \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=greg@kroah.com \
--cc=hintak.leung@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.