From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M2uuK-0001v3-LI for mharc-grub-devel@gnu.org; Sat, 09 May 2009 18:20:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M2uuI-0001tD-JJ for grub-devel@gnu.org; Sat, 09 May 2009 18:20:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M2uuE-0001ph-Pc for grub-devel@gnu.org; Sat, 09 May 2009 18:20:34 -0400 Received: from [199.232.76.173] (port=47457 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M2uuE-0001pe-Ka for grub-devel@gnu.org; Sat, 09 May 2009 18:20:30 -0400 Received: from mail-bw0-f161.google.com ([209.85.218.161]:59190) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M2uuE-0005nU-58 for grub-devel@gnu.org; Sat, 09 May 2009 18:20:30 -0400 Received: by bwz5 with SMTP id 5so2067074bwz.42 for ; Sat, 09 May 2009 15:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=ZT3gQhp2g6QZ09+7TIyRKuhKs8kPrqwmLcHtih4TQYI=; b=csTpNkJclrWk9dVCh3nonVNQ1wI3/RkaV0GyQtwSFy/AoGp+CLqZZ3iA3GTTi0GlEj YRaZ1q29dRmwmEgD9F4MQQC99B/jMuBmekyj7Az9S40Kv+9SkzAn4wlMEevk7DnIYEMS am0X+v/uLiTJwwuzt3xh6kCAfFUaTOSpLyMqU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=Tu2NmZS+K5ktxWbMpI035hA4zkzKMo5ZySuwkN9KCngyklOGFMsKuYN3Pb2NMdJCmx tF3hxzkPnXuDn7vbXc6Pzan37f4BiOU7YSw7f8ltyWateHJq4PYH0l6/n+n9Vrj3K8Oz nCnad3PuDB8iY2XUIYEvouADZSvm49qCKWS5A= Received: by 10.204.71.68 with SMTP id g4mr5187172bkj.81.1241907627254; Sat, 09 May 2009 15:20:27 -0700 (PDT) Received: from ?192.168.178.55? (p5B0CE24D.dip.t-dialin.net [91.12.226.77]) by mx.google.com with ESMTPS id 21sm2304720fxm.81.2009.05.09.15.20.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 09 May 2009 15:20:26 -0700 (PDT) Message-ID: <4A0601A9.6010706@googlemail.com> Date: Sun, 10 May 2009 00:20:25 +0200 From: Andreas User-Agent: Thunderbird 2.0.0.21 (X11/20090325) MIME-Version: 1.0 To: The development of GRUB 2 References: <49FB60BE.7090806@googlemail.com> <1241411539.26483.42.camel@mj> <49FF1BBE.4090001@googlemail.com> <1241471594.9047.28.camel@mj> <4A00AB64.3040904@googlemail.com> In-Reply-To: <4A00AB64.3040904@googlemail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] prevent duplicated entries due to symlinks X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 May 2009 22:20:34 -0000 ping? any problems still? Andreas Andreas Born schrieb: > Pavel Roskin schrieb: >> Suppose I have Linux 2.6.29 and 2.6.28. Your script makes entries for >> "Linux default" and "Linux 2.6.28". Then I install Linux 2.6.30 and >> don't run grub-mkconfig. Then I can boot Linux 2.6.30 and 2.6.28 form >> the menu, but not 2.6.29. >> >> Even if I run grub-mkconfig, there is still something I lose. By >> selecting "Linux default" I still don't know it it's Linux 2.6.30 or >> something else. >> >> For me, the convenience of not having to rerun grub-mkconfig doesn't >> outweigh the convenience of knowing what I'm loading. >> >> I know, it's have to argue about preferences, but if you want you >> changes to be accepted, you need to present a good case. >> > It's also that kind of discussion which eventually separates the wheat > from the chaff. Thus I welcome it. >> I would consider placing the kernel pointed to by the vmlinuz link to >> the first position of the Linux kernels. Another approach would be to >> have an entry for the link without suppressing any versioned entries. >> > Ok, I understand and if it is a preference why don't make it a > preference. :) > You can find attached a new version of the patch, which per default > will read the symlink and create an entry for the target, not the > symlink. You can change this behaviour with > "GRUB_USE_LINUX_SYMLINK=yes". If you define this environment variable > with that value, it will use the behaviour I implemented before. This > means it uses the symlink and ignores the kernel the symlink is > currently pointing at. > I think this is the best solution, because it prevents duplicated > entries (only one entry for symlink or symlink target) and it gives > the user the choice which behaviour he wants (rerun of grub-mkconfig > needed or not needed). > Is that solution all right? > >>>> Please specify where those names are used. Can you give the >>>> distribution name and version where such names are used? >>>> >>> Zenwalk, Slackware for example. I think more Slackware derivates are >>> using it too. >>> >> >> Let's add support for more versioned names first. That should be rather >> non-controversial. > I see no more versioned names which could be added for the existing > extension(s). There is initrd-. and > initrd.-. Whereas can either be $version or > $alt_version and can be "img" or "gz" ("gz" is new) and at the > very end as a last resort initrd.img initrd.gz and initrd.splash are > tried in that order (that's also new). Roughly speaking only new > fallback options. > Do you see a problem there or do you have a concrete versioned name to > add? > > Andreas