From: Amos Jeffries <squid3@treenet.co.nz>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: kaber@trash.net, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 07/11] netfilter: xtables: reduce indent level by one
Date: Mon, 11 May 2009 01:39:14 +1200 [thread overview]
Message-ID: <4A06D902.80003@treenet.co.nz> (raw)
In-Reply-To: <alpine.LSU.2.00.0905090553080.13691@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Saturday 2009-05-09 04:08, Amos Jeffries wrote:
>> Jan Engelhardt wrote:
>>> Cosmetic only. Transformation applied:
>>>
>>> -if (foo) { long block; } else { short block; }
>>> +if (!foo) { short block; continue; } long block;
>>>
>>> - if (IPT_MATCH_ITERATE(e, do_match, skb, &mtpar) != 0)
>>> - goto no_match;
>>> + if (IPT_MATCH_ITERATE(e, do_match, skb, &mtpar) != 0)
>>> + goto no_match;
>> Didn't your patch just earlier remove these no_match jumps from xtables?
>
> You are looking at patch #07/11, the gotos are removed in patch #08/11.
Ah, the weirdness introduced by splitting patches in to small tasks.
Gotcha.
Amos
next prev parent reply other threads:[~2009-05-10 13:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 9:26 kernel/iptables patches Jan Engelhardt
2009-05-08 9:26 ` [PATCH 01/11] netfilter: xtables: use NFPROTO_ for xt_proto_init callsites Jan Engelhardt
2009-05-08 9:26 ` [PATCH 02/11] netfilter: queue: use NFPROTO_ for queue callsites Jan Engelhardt
2009-05-08 9:26 ` [PATCH 03/11] netfilter: xtables: use NFPROTO_ in standard targets Jan Engelhardt
2009-05-08 9:26 ` [PATCH 04/11] netfilter: xtables: remove redundant casts Jan Engelhardt
2009-05-08 9:26 ` [PATCH 05/11] netfilter: xtables: fix const inconsistency Jan Engelhardt
2009-05-08 9:26 ` [PATCH 06/11] netfilter: xtables: consolidate open-coded logic Jan Engelhardt
2009-05-08 9:26 ` [PATCH 07/11] netfilter: xtables: reduce indent level by one Jan Engelhardt
2009-05-09 2:08 ` Amos Jeffries
2009-05-09 4:00 ` Jan Engelhardt
2009-05-10 13:39 ` Amos Jeffries [this message]
2009-05-08 9:26 ` [PATCH 08/11] netfilter: xtables: remove some goto Jan Engelhardt
2009-05-08 9:26 ` [PATCH 09/11] netfilter: xtables: remove another level of indent Jan Engelhardt
2009-05-08 9:26 ` [PATCH 10/11] netfilter: xtables: consolidate comefrom debug cast access Jan Engelhardt
2009-05-08 9:26 ` [PATCH 11/11] netfilter: xtables: print hook name instead of mask Jan Engelhardt
2009-05-09 2:06 ` Amos Jeffries
2009-06-01 11:00 ` kernel/iptables patches Jan Engelhardt
2009-06-02 11:53 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A06D902.80003@treenet.co.nz \
--to=squid3@treenet.co.nz \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.