All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumba <kumba@gentoo.org>
To: Johannes Dickgreber <tanzy@gmx.de>
Cc: Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: Help getting IP30/Octane fixed?
Date: Sun, 10 May 2009 14:57:07 -0400	[thread overview]
Message-ID: <4A072383.3010109@gentoo.org> (raw)
In-Reply-To: <4A0717AA.8060603@gmx.de>

Johannes Dickgreber wrote:

> This is whats wrong with SMP: from file include/asm/mach-ip30/heart.h
> 
> #define HEART_IMR(x)		((volatile ulong *)0x900000000ff10000 + (8 * (x)))
> 
> I schould be
> 
> #define HEART_IMR(x)		((volatile ulong *)0x900000000ff10000 + (x))
> 
> or it schould be
> 
> #define HEART_IMR(x)		((volatile ulong *) (0x900000000ff10000 + (8 * (x))))
> 
> The IRQ MASK Register for the different CPUs are side by side.
> In your version the factor 8 is used twice. First explicit inside the braces
> and second, because of the pointer to ulong implicit done by the
> compiler.
> I checked it by dissambling the code and my smp-kernel is working if i start
> only with one cpu. With 2 cpus the smp-kernel is booting, but the init process
> hangs then.

I'll have to test this when I get a new SMP module in.  Found a cheap R10K 
(yuck) on eBay for real cheap that'll suffice.  My R12000-300MHz refused to post 
at all (LED didn't even change to red, but the PROM would process NMI resets, 
oddly enough).

Ricardo (ricmm on IRC) explained it as this:

<ricmm> the baseline problem is that the secondary CPU's ipi irq is not 
triggering, the first one works
<ricmm> and smp_call_function() is calling an init function on both CPUs with a 
wait_for_completion flag set
<ricmm> but the second CPU will never run the function as the irq is not 
happening, therefore the flag will remain set
<ricmm> and smp_call_function() will spin waiting for the completion


> the revert is not needed anymore, because of code in arch/mips/pci/ops-bridge.c
> look for the function emulate_ioc3_cfg

Awesome, that's great to know!


> i have done some more work on the older patches and have a working kernel.
> if someone wants this patch, i can send it.

I'll take a look at it and see if I can integrate it into what I already have. 
Do you have it broken out into separate changes for the IOC3 metadriver and for 
the core IP30 code?


Thanks!

-- 
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org

"The past tempts us, the present confuses us, the future frightens us.  And our 
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic

  reply	other threads:[~2009-05-10 18:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09 23:21 Help getting IP30/Octane fixed? Kumba
2009-05-10 18:06 ` Johannes Dickgreber
2009-05-10 18:57   ` Kumba [this message]
2009-05-16 19:05     ` Johannes Dickgreber
2009-05-19  7:12       ` Kumba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A072383.3010109@gentoo.org \
    --to=kumba@gentoo.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tanzy@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.