From: Johannes Sixt <j.sixt@viscovery.net>
To: Paul Mackerras <paulus@samba.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] gitk: use --textconv to generate diff text
Date: Mon, 11 May 2009 09:18:56 +0200 [thread overview]
Message-ID: <4A07D160.9020709@viscovery.net> (raw)
From: Johannes Sixt <j6t@kdbg.org>
Date: Tue, 28 Apr 2009 14:03:54 +0200
For the most part gitk's focus is on showing history and changes in
a human readable form. For this reason, it makes sense to generate
the patch text in the diff view using --textconv so that textconv drivers
are used if they are defined.
gitk can also generate patches, but we do not use --textconv because
such patches could not be applied.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
gitk-git/gitk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 09eac46..a8a6022 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -7194,7 +7194,7 @@ proc getblobdiffs {ids} {
global limitdiffs vfilelimit curview
global diffencoding targetline diffnparents
- set cmd [diffcmd $ids "-p -C --cc --no-commit-id -U$diffcontext"]
+ set cmd [diffcmd $ids "-p --textconv -C --cc --no-commit-id -U$diffcontext"]
if {$ignorespace} {
append cmd " -w"
}
--
1.6.3.1007.g03ec
next reply other threads:[~2009-05-11 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 7:18 Johannes Sixt [this message]
2009-05-11 7:34 ` [PATCH] gitk: use --textconv to generate diff text Johannes Sixt
2009-05-11 9:13 ` Jeff King
2009-05-11 21:20 ` Junio C Hamano
2009-05-11 21:59 ` Paul Mackerras
2009-05-11 22:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A07D160.9020709@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.