Re: [PATCH #upstream] ahci: misc cleanups for EM stuff

[Jeff Garzik <jeff@garzik.org>]

Tejun Heo wrote:
> Make the following EM related cleanups.
> 
> * Use msleep(1) instead of udelay(100) and reduce retry count to 5.
> * s/MAX_SLOTS/EM_MAX_SLOTS/
> * s/MAX_RETRY/EM_MAX_RETRY/
> 
> [ Impact: cleanup, use of longer and fewer msleep() instead of udelay() ]
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
>  drivers/ata/ahci.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 3489085..65677b0 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -77,8 +77,8 @@ static ssize_t ahci_led_store(struct ata_port *ap, const char *buf,
>  			      size_t size);
>  static ssize_t ahci_transmit_led_message(struct ata_port *ap, u32 state,
>  					ssize_t size);
> -#define MAX_SLOTS 8
> -#define MAX_RETRY 15
> +#define EM_MAX_SLOTS 8
> +#define EM_MAX_RETRY 5
>  
>  enum {
>  	AHCI_PCI_BAR		= 5,

If you are going to change this, please move these into 'enum' where 
they belong...

	Jeff