From: "H. Peter Anvin" <hpa@zytor.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Marc Dionne <marc.c.dionne@gmail.com>,
Eric Paris <eparis@redhat.com>,
Eric Paris <eparis@parisplace.org>,
Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
sukadev@us.ibm.com, linux-kernel@vger.kernel.org,
jbacik@redhat.com
Subject: Re: [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts
Date: Mon, 11 May 2009 15:46:56 -0700 [thread overview]
Message-ID: <4A08AAE0.6030300@zytor.com> (raw)
In-Reply-To: <20090511223718.GA18528@us.ibm.com>
Serge E. Hallyn wrote:
> Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
> ...
>
>> >From 2f7746f4df78ff57125c4714f0cd64e739ccf804 Mon Sep 17 00:00:00 2001
>> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
>> Date: Mon, 11 May 2009 13:11:11 -0700
>> Subject: [PATCH] devpts: Correctly set default options
>>
>> devpts_get_sb() calls memset(0) to clear mount options and calls
>> parse_mount_options() if user specified any mount options. The memset(0) is
>> bogus since the 'mode' and 'ptmxmode' options are non-zero by default.
>> parse_mount_options() restores options to default anyway and can properly deal
>> with NULL mount options.
>>
>> So in devpts_get_sb() remove memset(0) and call parse_mount_options() even for
>> NULL mount options.
>>
>> Bug reported by Eric Paris: http://lkml.org/lkml/2009/5/7/448.
>
> Would you almost say... Reported-by: ? :)
>> Signed-off-by: Sukadev Bhattiprolu (sukadev@us.ibm.com)
>
> Looks good.
>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
>
Reviewed-by: H. Peter Anvin <hpa@zytor.com>
-hpa
next prev parent reply other threads:[~2009-05-11 22:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 18:08 [PATCH 0/5][v2] Simplify devpts code Sukadev Bhattiprolu
2009-03-07 18:10 ` Sukadev Bhattiprolu
2009-03-07 18:17 ` Sukadev Bhattiprolu
2009-03-07 18:11 ` [v3][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-03-07 18:11 ` [v3][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-03-07 18:12 ` [v3][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-03-07 18:12 ` [v3][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-05-07 20:35 ` Eric Paris
2009-05-07 21:24 ` Sukadev Bhattiprolu
2009-05-07 22:33 ` Eric Paris
2009-05-07 23:18 ` [v3][PATCH 5/5] Merge code for single and multiple-instancemounts Sukadev Bhattiprolu
2009-05-07 23:21 ` [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts Sukadev Bhattiprolu
2009-05-08 13:53 ` Peter Staubach
2009-05-09 3:17 ` Marc Dionne
2009-05-11 22:15 ` Sukadev Bhattiprolu
2009-05-11 22:19 ` H. Peter Anvin
2009-05-11 22:37 ` [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts Serge E. Hallyn
2009-05-11 22:46 ` H. Peter Anvin [this message]
2009-05-11 22:40 ` [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts Andrew Morton
2009-05-11 23:09 ` Eric Paris
2009-05-11 23:00 ` Marc Dionne
2009-03-07 18:14 ` [v3][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-03-07 18:16 ` [v3][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A08AAE0.6030300@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=hch@lst.de \
--cc=jbacik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=serue@us.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.