From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 0/1] Conntrack event generation control, kernel part Date: Tue, 12 May 2009 15:23:04 +0200 Message-ID: <4A097838.1080905@netfilter.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jan Engelhardt , Patrick McHardy , netfilter-devel@vger.kernel.org To: Jozsef Kadlecsik Return-path: Received: from mail.us.es ([193.147.175.20]:34814 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752703AbZELNXO (ORCPT ); Tue, 12 May 2009 09:23:14 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jozsef Kadlecsik wrote: > Hi Jan, > > On Tue, 12 May 2009, Jan Engelhardt wrote: > >> On Tuesday 2009-05-12 13:52, Jozsef Kadlecsik wrote: >> >>> diff --git a/net/netfilter/xt_CONNMARK.c b/net/netfilter/xt_CONNMARK.c >>> index d6e5ab4..86bc5ea 100644 >>> --- a/net/netfilter/xt_CONNMARK.c >>> +++ b/net/netfilter/xt_CONNMARK.c >>> + >>> +struct compat_xt_connmark_tginfo1 { >>> + __u32 ctmark, ctmask, nfmask; >>> + __u8 mode; >>> + __u8 __pad1; >>> + __u16 __pad2; >>> +}; >> v1 does not need a compat mode, because it does not use 'int' or 'long'. >> Note: 'compat' here means "32-bit userspace with a 64-bit kernel". It >> does not mean converting v1 to v2. > > Ahh, I'm blind, thanks! And the comments on the userspace part too - I'm > going to fix and resend the patches. Well, let's talk about the forest before looking at the trees :) -- "Los honestos son inadaptados sociales" -- Les Luthiers