Re: [PATCH 1/2] replace drop_interrupt_shadow by set_interrupt_shadow

[Avi Kivity <avi@redhat.com>]

Glauber Costa wrote:
> This patch replaces drop_interrupt_shadow with the more
> general set_interrupt_shadow, that can either drop or raise
> it, depending on its parameter.
>
>  }
>  
> +static u32 svm_get_interrupt_shadow(struct kvm_vcpu *vcpu, int mask)
> +{
> +	struct vcpu_svm *svm = to_svm(vcpu);
> +	u32 ret = 0;
> +
> +	if (svm->vmcb->control.int_state & SVM_INTERRUPT_SHADOW_MASK)
> +		ret |= X86_SHADOW_INT_STI && X86_SHADOW_INT_MOV_SS;
> +	return ret & mask;
> +}
>   

&& -> |.

> +
> +static void vmx_set_interrupt_shadow(struct kvm_vcpu *vcpu, int mask)
> +{
> +	u32 interruptibility_old = vmcs_read32(GUEST_INTERRUPTIBILITY_INFO);
> +	u32 interruptibility = interruptibility_old;
> +
> +	interruptibility &= ~((GUEST_INTR_STATE_STI | GUEST_INTR_STATE_MOV_SS));
>   

May drop one layer of parentheses.



-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.