All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Simon <tobias.simon@sp-ss.de>
To: linux-mtd@lists.infradead.org
Subject: mtd_dataflash bug
Date: Wed, 13 May 2009 03:15:36 +0200	[thread overview]
Message-ID: <4A0A1F38.6000500@sp-ss.de> (raw)

Hello List,

i have figured out a bug in mtd_datflash.c of kernel 2.6.29, which 
causes my ARM bootloader to be killed with every "erase" operation on 
arbitrary adresses. The fix is:

--- linux-2.6.29.2-a/drivers/mtd/devices/mtd_dataflash.c  2009-05-13 
03:11:16.000000000 +0200
+++ linux-2.6.29.2-b/drivers/mtd/devices/mtd_dataflash.c     2009-05-13 
03:13:30.000000000 +0200
@@ -184,7 +184,7 @@
                /* Calculate flash page address; use block erase (for 
speed) if
                 * we're at a block boundary and need to erase the whole 
block.
                 */
-               pageaddr = div_u64(instr->len, priv->page_size);
+               pageaddr = div_u64(instr->addr, priv->page_size);
                do_block = (pageaddr & 0x7) == 0 && instr->len >= blocksize;
                pageaddr = pageaddr << priv->page_offset;

Regards,
Tobias

             reply	other threads:[~2009-05-13 12:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13  1:15 Tobias Simon [this message]
2009-05-13 12:12 ` mtd_dataflash bug Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0A1F38.6000500@sp-ss.de \
    --to=tobias.simon@sp-ss.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.