Re: [PATCH 2/2] MIPS: Replace some magic numbers with symbolic values in tlbex.c (v2)

[David Daney <ddaney@caviumnetworks.com>]

Well I replied to the wrong message and screwed up the subject.  So
Ignore this one and I will send it again properly

David Daney

David Daney wrote:
> The logic used to split the r4000 refill handler is liberally
> sprinkled with magic numbers.  We attempt to explain what they are and
> normalize them against a new symbolic value (MIPS64_REFILL_INSNS).
> 
> Changes from v1:  Corrected spelling in comment.
> 
> CC: David VomLehn <dvomlehn@cisco.com>
> Reviewed-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
> 
> Please use this version instead of the original 2/2.
> 
>  arch/mips/mm/tlbex.c |   34 ++++++++++++++++++++++++++--------
>  1 files changed, 26 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 4dc4f3e..cbc09de 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -649,6 +649,14 @@ static void __cpuinit build_update_entries(u32 **p, unsigned int tmp,
>  #endif