All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: ayan@marvell.com
Cc: linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com
Subject: Re: [PATCH 5/5] mvsas: optimization of code
Date: Thu, 14 May 2009 00:41:23 -0400	[thread overview]
Message-ID: <4A0BA0F3.1040906@garzik.org> (raw)
In-Reply-To: <20090511172530.GB9720@Andy.marvell.com>

Andy Yan wrote:
>>From 698781e21a8595159a84a8c91b6bfa26d1a99108 Mon Sep 17 00:00:00 2001
> From: Andy Yan <ayan@marvell.com>
> Date: Mon, 11 May 2009 22:19:25 +0800
> Subject: [PATCH 5/5] mvsas: optimization of code
> 
> Using sticky field to improve retrieve performance.
> 
> Signed-off-by: Ying Chu <jasonchu@marvell.com>
> Signed-off-by: Andy Yan <ayan@marvell.com>
> Signed-off-by: Ke Wei <kewei@marvell.com>

Please revise this patch, to remove all C casts from a void pointer.

Separately, please submit a patch #6 that audits the rest of the driver, 
and removes all casts to or from a void pointer.

Rationale:  Standard kernel policy.  Casts to/from void* are

	- unnecessary

	- may hide bugs, if a mistake is made when changing
	  the underlying C type.

The Linux kernel does its best to be "type aware", and we rely heavily 
on the compiler to warn us of potential problems.



      reply	other threads:[~2009-05-14  4:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 17:25 [PATCH 5/5] mvsas: optimization of code Andy Yan
2009-05-14  4:41 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0BA0F3.1040906@garzik.org \
    --to=jeff@garzik.org \
    --cc=ayan@marvell.com \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.