From: Neil Turton <nturton@solarflare.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org
Subject: [PATCH] Fixed an off-by-one error in the AMD IOMMU driver.
Date: Thu, 14 May 2009 14:00:35 +0100 [thread overview]
Message-ID: <4A0C15F3.1090601@solarflare.com> (raw)
The variable amd_iommu_last_bdf holds the maximum bdf of any device
controlled by an IOMMU, so the number of device entries needed is
amd_iommu_last_bdf+1. The function tbl_size used amd_iommu_last_bdf
instead. This would be a problem if the last device were a large
enough power of 2.
Signed-off-by: Neil Turton <nturton@solarflare.com>
---
arch/x86/kernel/amd_iommu_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 42c33ce..61479ba 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -175,7 +175,7 @@ static inline void update_last_devid(u16 devid)
static inline unsigned long tbl_size(int entry_size)
{
unsigned shift = PAGE_SHIFT +
- get_order(amd_iommu_last_bdf * entry_size);
+ get_order(((int)amd_iommu_last_bdf+1) * entry_size);
return 1UL << shift;
}
--
1.5.5
next reply other threads:[~2009-05-14 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 13:00 Neil Turton [this message]
2009-05-14 13:47 ` [PATCH] Fixed an off-by-one error in the AMD IOMMU driver Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C15F3.1090601@solarflare.com \
--to=nturton@solarflare.com \
--cc=Joerg.Roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.