From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Colp Subject: Re: [PATCH] Fix get_page_from_l1eandcleanup_page_cacheattr to use PGC_cacheattr_mask Date: Fri, 15 May 2009 10:56:34 +0100 Message-ID: <4A0D3C52.4090700@citrix.com> References: <4A0D529E0200007800001120@vpn.id2.novell.com> <4A0D57F50200007800001153@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A0D57F50200007800001153@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >>>> Keir Fraser 15.05.09 11:40 >>> >> On 15/05/2009 10:31, "Jan Beulich" wrote: >> >>>>>> Patrick Colp 15.05.09 11:01 >>> >>>> # HG changeset patch >>>> # User Patrick Colp >>>> # Date 1242295647 -3600 >>>> # Node ID c5098f5c5caf4174bd2e46d49d7b65109203f7c5 >>>> # Parent 2522cc95efd2f3fadf7342d18fe86e8f37f89c2a >>>> Fix get_page_from_l1e and cleanup_page_cacheattr to use PGC_cacheattr_mask. >>> Could you indicate what it is that you fix here? >> I assume it's just getting rid of the open-coded 7. > > So would I have thought by looking at the patch, but the word 'fix' in the subject > made me thing there was something more subtle that I didn't spot... > > Jan Nah, just a poor word choice. "Changed" would probably have been better. Patrick