From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 13/13] libata: Media rotation rate and form factor heuristics Date: Fri, 15 May 2009 14:17:45 -0400 Message-ID: <4A0DB1C9.9090502@garzik.org> References: <1242362435-11953-1-git-send-email-martin.petersen@oracle.com> <1242362435-11953-14-git-send-email-martin.petersen@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:39803 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763454AbZEOSSI (ORCPT ); Fri, 15 May 2009 14:18:08 -0400 In-Reply-To: <1242362435-11953-14-git-send-email-martin.petersen@oracle.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: "Martin K. Petersen" Cc: rwheeler@redhat.com, snitzer@redhat.com, neilb@suse.de, James.Bottomley@hansenpartnership.com, jens.axboe@oracle.com, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org Martin K. Petersen wrote: > From: Martin K. Petersen > > This patch provides new heuristics for parsing both the form factor and > media rotation rate ATA IDENFITY words. > > The reported ATA version must be 7 or greater and the device must return > values defined as valid in the standard. Only then are the > characteristics reported to SCSI via the VPD B1 page. > > This seems like a reasonable compromise to me considering that we have > been shipping several kernel releases that key off the rotation rate bit > without any version checking whatsoever. With no complaints so far. > > Signed-off-by: Martin K. Petersen > --- > drivers/ata/libata-scsi.c | 15 ++++++--------- > include/linux/ata.h | 28 ++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 9 deletions(-) applied, after dropping the NONROT bit as inappropriate for 2.6.30-rc (which is where I applied the rest)