All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
	Stefano Brivio <stefano.brivio@polimi.it>,
	wireless <linux-wireless@vger.kernel.org>,
	Broadcom Linux <bcm43xx-dev@lists.berlios.de>
Subject: Re: [PATCH 1/2] b43legacy: Remove unnecessary MMIO in interrupt hotpath
Date: Fri, 15 May 2009 15:39:00 -0500	[thread overview]
Message-ID: <4A0DD2E4.3090802@lwfinger.net> (raw)
In-Reply-To: <200905150154.40819.mb@bu3sch.de>

Michael Buesch wrote:
> 
> This is not correct. Ring1 is used for transmission.
> With this patch applied, you won't receive error notification interrupts
> for the TX ring anymore.
> And ring3 is used for transmission status reporting on old devices.
> This patch breaks it for these devices.

Thanks for the comments. I had thought that you had signed off on Stefano's
original posting of this patch, which was sent to me for testing. I obviously
misunderstood.

V2 will not touch any of this part of the code. If there are DMA reason codes
that do not need to be used, they can be eliminated in a future patch.

Larry




      reply	other threads:[~2009-05-15 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 23:20 [PATCH 1/2] b43legacy: Remove unnecessary MMIO in interrupt hotpath Larry Finger
2009-05-14 23:54 ` Michael Buesch
2009-05-15 20:39   ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0DD2E4.3090802@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=stefano.brivio@polimi.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.