All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	"David S. Miller" <davem@davemloft.net>,
	Vincent Steenhoute <vsteenhoute@novell.com>,
	Martin Michlmayr <tbm@cyrius.com>,
	Ivan Vecera <ivecera@redhat.com>,
	Edward Hsu <edward_hsu@realtek.com.tw>,
	Andrew Morton <akpm@linux-foundation.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] r8169: allow true forced mode setting
Date: Sat, 16 May 2009 21:57:10 +0200	[thread overview]
Message-ID: <4A0F1A96.8070208@gmail.com> (raw)
In-Reply-To: <200905161450.38281.jdelvare@suse.de>

zOn 05/16/2009 02:50 PM, Jean Delvare wrote:

> If I read the code correctly, Realtek's driver (v6.010.00) only
> applies the quirk for RTL8169S and RTL8110S chips (what I have) and
> not the original RTL8169. Your code applies the quirk to all 3
> chips. Is this on purpose? Or am I missing something?

For reference, there it's the latest source code of Realtek drivers 
r8101/r8168/r8169 :

ftp://WebUser:DAx7h9V@202.65.194.212/cn/nic/r8101-1.012.00.tar.bz2
ftp://WebUser:DAx7h9V@202.65.194.212/cn/nic/r8168-8.012.00.tar.bz2
ftp://WebUser:DAx7h9V@202.65.194.212/cn/nic/r8169-6.010.00.tar.bz2

>> (...)
>> +	if (tp->mac_version <= RTL_GIGA_MAC_VER_03) {
>> +		if ((speed == SPEED_100) && (autoneg != AUTONEG_ENABLE)) {
>> +			mdio_write(ioaddr, 0x17, 0x2138);
>> +			mdio_write(ioaddr, 0x0e, 0x0260);
>> +		} else {
>> +			mdio_write(ioaddr, 0x17, 0x2108);
>> +			mdio_write(ioaddr, 0x0e, 0x0000);
>> +		}
>> +	}
>> +
>>  	return 0;
>>  }

-thanks-

regards,

-- 
Polycommander, Erkowit, Urquiola, Andros Patria, Cason, Aegean Sea, Prestige, ...

  reply	other threads:[~2009-05-16 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 21:46 [PATCH 2/2] r8169: allow true forced mode setting Francois Romieu
2009-05-16 12:50 ` Jean Delvare
2009-05-16 19:57   ` Xose Vazquez Perez [this message]
2009-05-17 10:34   ` Francois Romieu
2009-05-19  2:25 ` David Miller
2009-05-19 20:46   ` Francois Romieu
2009-05-19 21:32     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0F1A96.8070208@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=edward_hsu@realtek.com.tw \
    --cc=ivecera@redhat.com \
    --cc=jdelvare@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=tbm@cyrius.com \
    --cc=vsteenhoute@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.