From: Avi Kivity <avi@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mark McLoughlin <markmc@redhat.com>,
dlaor@redhat.com, netdev@vger.kernel.org,
Dor Laor <dor@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC)
Date: Sun, 17 May 2009 09:27:01 +0300 [thread overview]
Message-ID: <4A0FAE35.3040608@redhat.com> (raw)
In-Reply-To: <200905171134.31285.rusty@rustcorp.com.au>
Rusty Russell wrote:
>
> +static void adjust_threshold(struct vring_virtqueue *vq,
> + unsigned int out, unsigned int in)
> +{
> + /* There are really two species of virtqueue, and it matters here.
> + * If there are no output parts, it's a "normally full" receive queue,
> + * otherwise it's a "normally empty" send queue. */
>
This comment is true for networking, but not for block. ++overkill with
a ->adjust_threshold op.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-05-17 6:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 17:10 [PATCH 0/3] virtio: indirect ring entries Mark McLoughlin
2008-12-18 17:10 ` [PATCH 1/3] virtio: teach virtio_has_feature() about transport features Mark McLoughlin
2008-12-18 17:10 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Mark McLoughlin
2008-12-18 17:10 ` [PATCH 3/3] lguest: add support for indirect ring entries Mark McLoughlin
2008-12-20 11:38 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Ingo Oeser
2008-12-22 10:17 ` Mark McLoughlin
2008-12-22 10:17 ` Mark McLoughlin
2008-12-20 11:38 ` Ingo Oeser
2009-04-21 12:59 ` Mark McLoughlin
2009-04-21 12:59 ` Mark McLoughlin
2009-04-27 7:43 ` Dor Laor
2009-05-04 2:19 ` Rusty Russell
2009-05-11 17:10 ` Mark McLoughlin
2009-05-11 17:11 ` [PATCH 1/3] virtio: teach virtio_has_feature() about transport features Mark McLoughlin
2009-05-11 17:11 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Mark McLoughlin
2009-05-11 17:11 ` [PATCH 3/3] lguest: add support for indirect ring entries Mark McLoughlin
2009-05-12 14:23 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Rusty Russell
2009-05-12 14:23 ` Rusty Russell
2009-05-17 2:04 ` Rusty Russell
2009-05-17 2:04 ` Rusty Russell
2009-05-17 6:27 ` Avi Kivity
2009-05-17 6:27 ` Avi Kivity [this message]
2009-05-17 14:16 ` Rusty Russell
2009-05-17 15:05 ` Avi Kivity
2009-05-19 8:15 ` Rusty Russell
2009-05-19 8:15 ` Rusty Russell
2009-05-17 15:05 ` Avi Kivity
2009-05-17 14:16 ` Rusty Russell
2009-05-11 17:10 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0FAE35.3040608@redhat.com \
--to=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=dor@redhat.com \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.