From: Arjan van de Ven <arjan@linux.intel.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Jakub Jelinek <jakub@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hugh@veritas.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix print out of function which called WARN_ON()
Date: Mon, 18 May 2009 07:11:47 -0700 [thread overview]
Message-ID: <4A116CA3.4050902@linux.intel.com> (raw)
In-Reply-To: <1242637778.20731.7.camel@zakaz.uk.xensource.com>
Ian Campbell wrote:
> On Sat, 2009-05-16 at 13:47 -0700, Linus Torvalds wrote:
>
>> - it uses '%pS' instead of of sprint_symbol
> [...]
>> - printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
>> - line, function);
>> + printk(KERN_WARNING "WARNING: at %s:%d %pS()\n", file, line, caller);
>
> Those parens end up looking pretty odd to me with the %pS:
> WARNING: at [...] local_bh_enable+0x68/0x80()
didn't we have a %pSomething that doesn't print those 2 hex parts ?
(It would allow us to keep the print format the same)
prev parent reply other threads:[~2009-05-18 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 16:17 [PATCH] Fix print out of function which called WARN_ON() Ian Campbell
2009-05-15 17:52 ` Linus Torvalds
2009-05-15 19:50 ` Andi Kleen
2009-05-16 20:47 ` Linus Torvalds
2009-05-17 14:43 ` Hugh Dickins
2009-05-17 22:18 ` Linus Torvalds
2009-05-17 22:24 ` David Miller
2009-05-17 22:47 ` Linus Torvalds
2009-05-17 22:45 ` Hugh Dickins
2009-05-17 22:54 ` Linus Torvalds
2009-05-18 9:09 ` Ian Campbell
2009-05-18 14:11 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A116CA3.4050902@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=Ian.Campbell@citrix.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hugh@veritas.com \
--cc=jakub@redhat.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.