From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen/blkfront: allow xenbus state transition to Closing->Closed when not Connected. Date: Mon, 18 May 2009 11:41:48 -0700 Message-ID: <4A11ABEC.4050301@goop.org> References: <1242650931.20731.41.camel@zakaz.uk.xensource.com> <1242650974-13056-2-git-send-email-ian.campbell@citrix.com> <4A119975.4000501@goop.org> <20090518183420.GO4140@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090518183420.GO4140@kernel.dk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jens Axboe Cc: xen-devel@lists.xensource.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org Jens Axboe wrote: > On Mon, May 18 2009, Jeremy Fitzhardinge wrote: > >> Ian Campbell wrote: >> >>> This situation can occur when attempting to attach a block device whose backend >>> is an empty physical CD-ROM driver. The backend in this case will go directly >>> from the Initialising state to Closing->Closed. Previously this would result in >>> a NULL pointer deref on info->gd (xenbus_dev_fatal does not return as a1a15ac5 >>> seems to expect) >>> >>> Signed-off-by: Ian Campbell >>> Cc: Jeremy Fitzhardinge >>> >>> >> Jens, does this look OK to you? >> >> Acked-by: Jeremy Fitzhardinge >> > > Looks fine, shall I add it for 2.6.30? Does it need a stable backport? > Yes please, and for .29. As far as I know there's been no change to blkfront, so it should apply as-is. There's another patch to go with it that I'm just having a closer look at. I'll probably send it your way shortly. Thanks, J