All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2.6.29.3 1/1] hwmon: added support for the
Date: Tue, 19 May 2009 09:11:15 +0000	[thread overview]
Message-ID: <4A1277B3.5000906@hhs.nl> (raw)
In-Reply-To: <9EE81EBECB70824985BE0EDA8DC9B5150214E42C@VIECLEX01.frequentis.frq>

On 05/19/2009 10:39 AM, Engelmayer Christian wrote:
> From: Christian Engelmayer<christian.engelmayer@frequentis.com>
>
> Added support for the GPIO definition/status registers and the alarm
> enable/status
> registers provided by the MAX6650/MAX6651 fan-speed regulator and monitor
> chips.
>
> Signed-off-by: Christian Engelmayer<christian.engelmayer@frequentis.com>

<snip>

Hmm,

I'm not sure we should be exporting gpio functionality like this. First of
all the gpio function usually is fixed by how the IC is wired up, so I would
expect that to be set by the BIOS / firmware. And when not, this should be
set through a board configuration file, exporting this to userspace feels wrong.

The same can be said for toggling the pin when its an output, its function will
depend upon how its wired up again, and I would expect some higher level interface
(like an ACPI interface or whatever) expose its functionality in a more sane way.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2009-05-19  9:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19  8:39 [lm-sensors] [PATCH 2.6.29.3 1/1] hwmon: added support for the Engelmayer Christian
2009-05-19  9:11 ` Hans de Goede [this message]
2009-05-19 10:45 ` Engelmayer Christian
2009-05-19 17:08 ` Hans de Goede
2009-05-19 20:52 ` Christian Engelmayer
2009-05-19 21:11 ` Jean Delvare
2009-05-20 10:52 ` Engelmayer Christian
2009-05-20 18:31 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1277B3.5000906@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.