From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/4] Nested SVM: Implement INVLPGA v2 Date: Tue, 19 May 2009 16:19:37 +0300 Message-ID: <4A12B1E9.1080904@redhat.com> References: <1242730443-15656-1-git-send-email-agraf@suse.de> <1242730443-15656-2-git-send-email-agraf@suse.de> <1242730443-15656-3-git-send-email-agraf@suse.de> <1242730443-15656-4-git-send-email-agraf@suse.de> <4A12AD0C.9030402@redhat.com> <1818B7EE-E513-4DE3-A77A-EC65186E0044@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joerg.roedel@amd.com, Marcelo Tosatti To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43957 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbZESNTm (ORCPT ); Tue, 19 May 2009 09:19:42 -0400 In-Reply-To: <1818B7EE-E513-4DE3-A77A-EC65186E0044@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: >> I think that for ASID!=0 you can actually do nothing. The guest >> entry is a cr3 switch, so we'll both get a tlb flush and a resync on >> any modified ptes. > > Right, the only situation I can imagine this isn't fulfilled is when > INVLPGA isn't trapped in the 1st level guest, but issued in the 2nd > level one. That should be rather rare though ;-). Good catch. Would be better to get it right; changing the test to asid != current_asid should suffice. -- error compiling committee.c: too many arguments to function