All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, joerg.roedel@amd.com
Subject: Re: [PATCH 3/4] Nested SVM: Implement INVLPGA v2
Date: Tue, 19 May 2009 19:35:00 +0300	[thread overview]
Message-ID: <4A12DFB4.8030000@redhat.com> (raw)
In-Reply-To: <E5D3E04D-246A-4336-A745-7896DDB15C8E@suse.de>

Alexander Graf wrote:
>>>> kvm_mmu_invlpg is cheap, better just invalidate the entry. If hyper-v
>>>> uses invlpga to invalidate TLB entries which it has updated pte's in
>>>> memory for, and you skip the invalidation now and somehow later use an
>>>> unsync spte, you're toast.
>>>>
>>>
>>> But won't the guest entry cause a resync?
>>
>> If its a cr3/cr4 exit, yes.
>
> Well it has to be. Either we're switching from one NPT to the other 
> (todo) or do a normal cr3+cr4 switch.
>
> So I guess we can optimize here. Is it worth it?
>

I think so.  We also need to make sure the entry causes a resync, even 
if cr3 doesn't change.

Oh, exit needs to force a resync as well, in case the guest foolishly 
let its guest touch its page tables and issue invlpga asid=0.

-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2009-05-19 16:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19 10:53 [PATCH 0/4] Add rudimentary Hyper-V guest support v2 Alexander Graf
2009-05-19 10:54 ` [PATCH 1/4] Add definition for IGNNE MSR Alexander Graf
2009-05-19 10:54   ` [PATCH 2/4] Implement Hyper-V MSRs v2 Alexander Graf
2009-05-19 10:54     ` [PATCH 3/4] Nested SVM: Implement INVLPGA v2 Alexander Graf
2009-05-19 10:54       ` [PATCH 4/4] Nested SVM: Improve interrupt injection v2 Alexander Graf
2009-05-19 13:22         ` Gleb Natapov
2009-06-15 11:47           ` Alexander Graf
2009-06-15 11:56             ` Gleb Natapov
2009-05-19 12:58       ` [PATCH 3/4] Nested SVM: Implement INVLPGA v2 Avi Kivity
2009-05-19 13:10         ` Alexander Graf
2009-05-19 13:19           ` Avi Kivity
2009-05-19 13:54         ` Marcelo Tosatti
2009-05-19 13:56           ` Avi Kivity
2009-05-19 13:58             ` Marcelo Tosatti
2009-05-19 15:18               ` Alexander Graf
2009-05-19 16:33                 ` Marcelo Tosatti
2009-05-19 16:35                 ` Avi Kivity [this message]
2009-05-19 12:52     ` [PATCH 2/4] Implement Hyper-V MSRs v2 Avi Kivity
2009-06-15 11:45       ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A12DFB4.8030000@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.