From: Masami Hiramatsu <mhiramat@redhat.com>
To: "Przemysław Pawełczyk" <przemyslaw@pawelczyk.it>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
kvm <kvm@vger.kernel.org>,
DLE <dle-develop@lists.sourceforge.net>,
Jim Keniston <jkenisto@us.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API
Date: Wed, 20 May 2009 18:48:02 -0400 [thread overview]
Message-ID: <4A1488A2.30706@redhat.com> (raw)
In-Reply-To: <40e92d5b0905201501i1548621xe1ee63aa88129a0@mail.gmail.com>
Przemysław Pawełczyk wrote:
> On Wed, May 20, 2009 at 22:58, Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
>> Changes from v5:
>
>> - Use /usr/bin/env to find awk
>
> This is fine, but not in the below case.
>
>> --- /dev/null
>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
>> @@ -0,0 +1,314 @@
>> +#!/usr/bin/env awk -f
>
> Depending on multi-argument shebang is IMO bad. In shebang generally
> (but not in all systems) everything after interpreter part is treated
> as the first argument. Therefore executing your gen-insn-attr-x86.awk
> is equivalent to:
>
> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
>
> which is obviously wrong.
Oops, right. Anyway, there is no reason that we make it
executable because it's always called from Makefile.
So, I think just removing that line is better way.
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-05-20 22:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 20:57 [PATCH -tip v6 0/5] tracing: kprobe-based event tracer and x86 instruction decoder Masami Hiramatsu
2009-05-20 20:57 ` Masami Hiramatsu
2009-05-20 20:58 ` [PATCH -tip v6 1/5] x86: instruction decorder API Masami Hiramatsu
2009-05-20 20:58 ` Masami Hiramatsu
2009-05-20 22:01 ` Przemysław Pawełczyk
2009-05-20 22:48 ` Masami Hiramatsu [this message]
2009-05-21 5:45 ` H. Peter Anvin
2009-05-21 15:52 ` Masami Hiramatsu
2009-05-21 17:29 ` [PATCH -tip v6.1 " Masami Hiramatsu
2009-05-21 17:29 ` Masami Hiramatsu
2009-05-21 17:29 ` Andi Kleen
2009-05-21 19:10 ` [PATCH -tip v6.1 1/5] x86: instruction decoder API Masami Hiramatsu
2009-05-20 20:58 ` [PATCH -tip v6 2/5] kprobes: checks probe address is instruction boudary on x86 Masami Hiramatsu
2009-05-20 20:58 ` Masami Hiramatsu
2009-05-20 20:58 ` [PATCH -tip v6 3/5] kprobes: cleanup fix_riprel() using insn decoder " Masami Hiramatsu
2009-05-20 20:58 ` Masami Hiramatsu
2009-05-20 20:58 ` [PATCH -tip v6 4/5] x86: add pt_regs register and stack access APIs Masami Hiramatsu
2009-05-20 20:58 ` [PATCH -tip v6 5/5] tracing: add kprobe-based event tracer Masami Hiramatsu
2009-05-20 20:58 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1488A2.30706@redhat.com \
--to=mhiramat@redhat.com \
--cc=ak@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=avi@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=przemyslaw@pawelczyk.it \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.