All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Zhenwen Xu <helight.xu@gmail.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, eparis@redhat.com
Subject: Re: [PATCH] remove function audit_receive_filter here in kerenl/audit.c
Date: Thu, 21 May 2009 11:06:55 +0800	[thread overview]
Message-ID: <4A14C54F.6040808@cn.fujitsu.com> (raw)
In-Reply-To: <20090521023111.GA4863@helight>

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 9442c35..40fc803 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -790,6 +790,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  		}
>  		/* fallthrough */
>  	case AUDIT_LIST:
> +	case AUDIT_LIST_RULES:
>  		err = audit_receive_filter(msg_type, NETLINK_CB(skb).pid,
>  					   uid, seq, data, nlmsg_len(nlh),
>  					   loginuid, sessionid, sid);
> @@ -807,12 +808,6 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  			audit_log_end(ab);
>  			return -EPERM;
>  		}
> -		/* fallthrough */

This patch is obviously wrong.

> -	case AUDIT_LIST_RULES:
> -		err = audit_receive_filter(msg_type, NETLINK_CB(skb).pid,
> -					   uid, seq, data, nlmsg_len(nlh),
> -					   loginuid, sessionid, sid);
> -		break;
>  	case AUDIT_TRIM:
>  		audit_trim_trees();
>  


      reply	other threads:[~2009-05-21  3:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21  2:31 [PATCH] remove function audit_receive_filter here in kerenl/audit.c Zhenwen Xu
2009-05-21  3:06 ` Li Zefan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A14C54F.6040808@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=eparis@redhat.com \
    --cc=helight.xu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.